Log error into test failures

crazytonyli · crazytonyli · commit 18d83829905d · 2024-02-19T11:45:16.000+13:00
diff --git a/WordPress/WordPressTest/BlockEditorSettingsServiceTests.swift b/WordPress/WordPressTest/BlockEditorSettingsServiceTests.swift
@@ -42,8 +42,8 @@ class BlockEditorSettingsServiceTests: CoreDataTestCase {
             case .success(let settings):
                 XCTAssertTrue(settings.hasChanges)
                 XCTAssertNotNil(settings.blockEditorSettings)
-            case .failure:
-                XCTFail()
+            case let .failure(error):
+                XCTFail("Unexpected failure: \(error)")
             }
             waitExpectation.fulfill()
         }
@@ -75,8 +75,8 @@ class BlockEditorSettingsServiceTests: CoreDataTestCase {
             case .success(let settings):
                 XCTAssertTrue(settings.hasChanges)
                 XCTAssertNotNil(settings.blockEditorSettings)
-            case .failure:
-                XCTFail()
+            case let .failure(error):
+                XCTFail("Unexpected failure: \(error)")
             }
             waitExpectation.fulfill()
         }
@@ -108,8 +108,8 @@ class BlockEditorSettingsServiceTests: CoreDataTestCase {
             case .success(let settings):
                 XCTAssertFalse(settings.hasChanges)
                 XCTAssertNotNil(settings.blockEditorSettings)
-            case .failure:
-                XCTFail()
+            case let .failure(error):
+                XCTFail("Unexpected failure: \(error)")
             }
             waitExpectation.fulfill()
         }
@@ -146,8 +146,8 @@ class BlockEditorSettingsServiceTests: CoreDataTestCase {
             case .success(let settings):
                 XCTAssertTrue(settings.hasChanges)
                 XCTAssertNotNil(settings.blockEditorSettings)
-            case .failure:
-                XCTFail()
+            case let .failure(error):
+                XCTFail("Unexpected failure: \(error)")
             }
             waitExpectation.fulfill()
         }
@@ -167,8 +167,8 @@ class BlockEditorSettingsServiceTests: CoreDataTestCase {
             case .success(let settings):
                 XCTAssertTrue(settings.hasChanges)
                 XCTAssertNotNil(settings.blockEditorSettings)
-            case .failure:
-                XCTFail()
+            case let .failure(error):
+                XCTFail("Unexpected failure: \(error)")
             }
             waitExpectation.fulfill()
         }
@@ -191,8 +191,8 @@ class BlockEditorSettingsServiceTests: CoreDataTestCase {
             case .success(let settings):
                 XCTAssertTrue(settings.hasChanges)
                 XCTAssertNotNil(settings.blockEditorSettings)
-            case .failure:
-                XCTFail()
+            case let .failure(error):
+                XCTFail("Unexpected failure: \(error)")
             }
             waitExpectation.fulfill()
         }
@@ -216,8 +216,8 @@ class BlockEditorSettingsServiceTests: CoreDataTestCase {
             case .success(let settings):
                 XCTAssertTrue(settings.hasChanges)
                 XCTAssertNotNil(settings.blockEditorSettings)
-            case .failure:
-                XCTFail()
+            case let .failure(error):
+                XCTFail("Unexpected failure: \(error)")
             }
             waitExpectation.fulfill()
         }
@@ -242,8 +242,8 @@ class BlockEditorSettingsServiceTests: CoreDataTestCase {
             case .success(let settings):
                 XCTAssertFalse(settings.hasChanges)
                 XCTAssertNotNil(settings.blockEditorSettings)
-            case .failure:
-                XCTFail()
+            case let .failure(error):
+                XCTFail("Unexpected failure: \(error)")
             }
             waitExpectation.fulfill()
         }

Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,8 @@ class BlockEditorSettingsServiceTests: CoreDataTestCase {`
`42`	`42`	`case .success(let settings):`
`43`	`43`	`XCTAssertTrue(settings.hasChanges)`
`44`	`44`	`XCTAssertNotNil(settings.blockEditorSettings)`
`45`		`- case .failure:`
`46`		`- XCTFail()`
	`45`	`+ case let .failure(error):`
	`46`	`+ XCTFail("Unexpected failure: \(error)")`
`47`	`47`	`}`
`48`	`48`	`waitExpectation.fulfill()`
`49`	`49`	`}`
`@@ -75,8 +75,8 @@ class BlockEditorSettingsServiceTests: CoreDataTestCase {`
`75`	`75`	`case .success(let settings):`
`76`	`76`	`XCTAssertTrue(settings.hasChanges)`
`77`	`77`	`XCTAssertNotNil(settings.blockEditorSettings)`
`78`		`- case .failure:`
`79`		`- XCTFail()`
	`78`	`+ case let .failure(error):`
	`79`	`+ XCTFail("Unexpected failure: \(error)")`
`80`	`80`	`}`
`81`	`81`	`waitExpectation.fulfill()`
`82`	`82`	`}`
`@@ -108,8 +108,8 @@ class BlockEditorSettingsServiceTests: CoreDataTestCase {`
`108`	`108`	`case .success(let settings):`
`109`	`109`	`XCTAssertFalse(settings.hasChanges)`
`110`	`110`	`XCTAssertNotNil(settings.blockEditorSettings)`
`111`		`- case .failure:`
`112`		`- XCTFail()`
	`111`	`+ case let .failure(error):`
	`112`	`+ XCTFail("Unexpected failure: \(error)")`
`113`	`113`	`}`
`114`	`114`	`waitExpectation.fulfill()`
`115`	`115`	`}`
`@@ -146,8 +146,8 @@ class BlockEditorSettingsServiceTests: CoreDataTestCase {`
`146`	`146`	`case .success(let settings):`
`147`	`147`	`XCTAssertTrue(settings.hasChanges)`
`148`	`148`	`XCTAssertNotNil(settings.blockEditorSettings)`
`149`		`- case .failure:`
`150`		`- XCTFail()`
	`149`	`+ case let .failure(error):`
	`150`	`+ XCTFail("Unexpected failure: \(error)")`
`151`	`151`	`}`
`152`	`152`	`waitExpectation.fulfill()`
`153`	`153`	`}`
`@@ -167,8 +167,8 @@ class BlockEditorSettingsServiceTests: CoreDataTestCase {`
`167`	`167`	`case .success(let settings):`
`168`	`168`	`XCTAssertTrue(settings.hasChanges)`
`169`	`169`	`XCTAssertNotNil(settings.blockEditorSettings)`
`170`		`- case .failure:`
`171`		`- XCTFail()`
	`170`	`+ case let .failure(error):`
	`171`	`+ XCTFail("Unexpected failure: \(error)")`
`172`	`172`	`}`
`173`	`173`	`waitExpectation.fulfill()`
`174`	`174`	`}`
`@@ -191,8 +191,8 @@ class BlockEditorSettingsServiceTests: CoreDataTestCase {`
`191`	`191`	`case .success(let settings):`
`192`	`192`	`XCTAssertTrue(settings.hasChanges)`
`193`	`193`	`XCTAssertNotNil(settings.blockEditorSettings)`
`194`		`- case .failure:`
`195`		`- XCTFail()`
	`194`	`+ case let .failure(error):`
	`195`	`+ XCTFail("Unexpected failure: \(error)")`
`196`	`196`	`}`
`197`	`197`	`waitExpectation.fulfill()`
`198`	`198`	`}`
`@@ -216,8 +216,8 @@ class BlockEditorSettingsServiceTests: CoreDataTestCase {`
`216`	`216`	`case .success(let settings):`
`217`	`217`	`XCTAssertTrue(settings.hasChanges)`
`218`	`218`	`XCTAssertNotNil(settings.blockEditorSettings)`
`219`		`- case .failure:`
`220`		`- XCTFail()`
	`219`	`+ case let .failure(error):`
	`220`	`+ XCTFail("Unexpected failure: \(error)")`
`221`	`221`	`}`
`222`	`222`	`waitExpectation.fulfill()`
`223`	`223`	`}`
`@@ -242,8 +242,8 @@ class BlockEditorSettingsServiceTests: CoreDataTestCase {`
`242`	`242`	`case .success(let settings):`
`243`	`243`	`XCTAssertFalse(settings.hasChanges)`
`244`	`244`	`XCTAssertNotNil(settings.blockEditorSettings)`
`245`		`- case .failure:`
`246`		`- XCTFail()`
	`245`	`+ case let .failure(error):`
	`246`	`+ XCTFail("Unexpected failure: \(error)")`
`247`	`247`	`}`
`248`	`248`	`waitExpectation.fulfill()`
`249`	`249`	`}`