Include freedesktop sdk TypeScript extension (#988)

Closes #975

TypeScript is still disabled by default for now but it's just a
gsetting.

Author: sonnyp

Makefile

@@ -4,7 +4,7 @@ SHELL:=/bin/bash -O globstar
 
 setup:
 	flatpak remote-add --user --if-not-exists flathub https://dl.flathub.org/repo/flathub.flatpakrepo
-	flatpak install --or-update --user --noninteractive flathub org.gnome.Sdk//47 org.flatpak.Builder org.freedesktop.Sdk.Extension.rust-stable//24.08 org.freedesktop.Sdk.Extension.vala//24.08 org.freedesktop.Sdk.Extension.llvm18//24.08 org.freedesktop.Sdk.Extension.node20//24.08 #org.freedesktop.Sdk.Extension.typescript//24.08
+	flatpak install --or-update --user --noninteractive flathub org.gnome.Sdk//47 org.flatpak.Builder org.freedesktop.Sdk.Extension.rust-stable//24.08 org.freedesktop.Sdk.Extension.vala//24.08 org.freedesktop.Sdk.Extension.llvm18//24.08 org.freedesktop.Sdk.Extension.node20//24.08 org.freedesktop.Sdk.Extension.typescript//24.08
 # flatpak remote-add --user --if-not-exists flathub-beta https://flathub.org/beta-repo/flathub-beta.flatpakrepo
 # flatpak remote-add --user --if-not-exists gnome-nightly https://nightly.gnome.org/gnome-nightly.flatpakrepo
 # flatpak install --or-update --user --noninteractive gnome-nightly org.gnome.Sdk//master

build-aux/re.sonny.Workbench.Devel.json

@@ -8,10 +8,11 @@
     "org.freedesktop.Sdk.Extension.vala",
     "org.freedesktop.Sdk.Extension.rust-stable",
     "org.freedesktop.Sdk.Extension.llvm18",
-    "org.freedesktop.Sdk.Extension.node20"
+    "org.freedesktop.Sdk.Extension.node20",
+    "org.freedesktop.Sdk.Extension.typescript"
   ],
   "build-options": {
-    "append-path": "/usr/lib/sdk/vala/bin:/usr/lib/sdk/rust-stable/bin:/usr/lib/sdk/node20/bin",
+    "append-path": "/usr/lib/sdk/vala/bin:/usr/lib/sdk/rust-stable/bin:/usr/lib/sdk/node20/bin:/usr/lib/sdk/typescript/bin",
     "append-ld-library-path": "/usr/lib/sdk/vala/lib"
   },
   "command": "workbench",

build-aux/re.sonny.Workbench.json

@@ -8,10 +8,11 @@
     "org.freedesktop.Sdk.Extension.vala",
     "org.freedesktop.Sdk.Extension.rust-stable",
     "org.freedesktop.Sdk.Extension.llvm18",
-    "org.freedesktop.Sdk.Extension.node20"
+    "org.freedesktop.Sdk.Extension.node20",
+    "org.freedesktop.Sdk.Extension.typescript"
   ],
   "build-options": {
-    "append-path": "/usr/lib/sdk/vala/bin:/usr/lib/sdk/rust-stable/bin:/usr/lib/sdk/node20/bin",
+    "append-path": "/usr/lib/sdk/vala/bin:/usr/lib/sdk/rust-stable/bin:/usr/lib/sdk/node20/bin:/usr/lib/sdk/typescript/bin",
     "append-ld-library-path": "/usr/lib/sdk/vala/lib"
   },
   "command": "workbench",

build-aux/wip/run.js

@@ -19,13 +19,12 @@ Gio._promisify(
   "wait_check_finish",
 );
 
-// const path = GLib.get_current_dir();
-const path = "/home/sonny/Projects/Workbench";
+const path = GLib.get_current_dir();
 console.debug(programInvocationName, programArgs);
 const argv = minimist(programArgs, { boolean: true });
 console.debug(argv);
 
-const [manifest_path] = argv._;
+const [manifest_path, ...arg] = argv._;
 if (!manifest_path) {
   // eslint-disable-next-line no-restricted-globals
   print(`${programInvocationName} [--verbose] [--debug] MANIFEST`);
@@ -124,7 +123,8 @@ await buildCommand(["meson", "install", "-C", "_build"]);
 // ]);
 
 // starts workbench
-await runCommand([manifest.command]);
+const command = arg.length ? arg : [manifest.command];
+await runCommand(command);
 
 function buildCommand(argv) {
   let PATH =
@@ -165,9 +165,9 @@ async function runCommand(argv) {
       `--bind-mount=/run/user/1000/doc=/run/user/1000/doc/by-app/${flatpak_id}`,
       ...manifest["finish-args"],
 
-      // Non default permissions
-      // see Permissions.js
-      // consider getting installed overrides instead
+      // Non default permissions, see Permissions.js
+      // consider getting installed overrides instead with
+      // flatpak override --user --show re.sonny.Workbench.Devel
       "--share=network",
       "--socket=pulseaudio",
       "--device=input",

data/app.metainfo.xml

@@ -55,7 +55,10 @@
         <p>Library:</p>
         <ul>
           <li>Add "Button Row" demo</li>
+          <li>Add "Gamepad" demo</li>
           <li>Add "List View with Sections" demo</li>
+          <li>Add "List View with a Tree" demo</li>
+          <li>Add "Bottom Sheet" demo</li>
           <li>Update "Spinner" to use AdwSpinner</li>
           <li>Port "Dialog" to Python</li>
           <li>Port "List View" to Python</li>
@@ -91,6 +94,7 @@
           <li>Port "Actions" to Vala</li>
           <li>Port "Dialog" to Vala</li>
           <li>Port "CSS Gradients" to Vala</li>
+          <li>Port "Snapshot" to Vala</li>
         </ul>
         <p>Dependencies:</p>
         <ul>

src/cli/main.js

@@ -87,7 +87,15 @@ const window = new Adw.ApplicationWindow();
 
 function createLSPClients({ root_uri }) {
   return Object.fromEntries(
-    ["javascript", "blueprint", "css", "vala", "rust", "python"].map((id) => {
+    [
+      "javascript",
+      "blueprint",
+      "css",
+      "vala",
+      "rust",
+      "python",
+      "typescript",
+    ].map((id) => {
       const lang = languages.find((language) => language.id === id);
       const lspc = createLSPClient({
         lang,
@@ -344,6 +352,73 @@ async function ci({ filenames }) {
       });
     }
 
+    const file_typescript = demo_dir.get_child("main.ts");
+    if (file_typescript.query_exists(null)) {
+      print(`  ${file_typescript.get_path()}`);
+
+      const uri = file_typescript.get_uri();
+      const languageId = "typescript";
+      let version = 0;
+
+      const [contents] = await file_typescript.load_contents_async(null);
+      const text = new TextDecoder().decode(contents);
+
+      await lsp_clients.typescript._notify("textDocument/didOpen", {
+        textDocument: {
+          uri,
+          languageId,
+          version: version++,
+          text,
+        },
+      });
+
+      const diagnostics = await waitForDiagnostics({
+        uri,
+        lspc: lsp_clients.typescript,
+      });
+      if (diagnostics.length > 0) {
+        printerr(serializeDiagnostics({ diagnostics }));
+        return false;
+      }
+      print(`  ✅ lints`);
+
+      const checks = await checkFile({
+        lspc: lsp_clients.typescript,
+        file: file_typescript,
+        lang: getLanguage("typescript"),
+        uri,
+      });
+      if (!checks) return false;
+
+      const js_object_ids = getCodeObjectIds(text);
+      for (const object_id of js_object_ids) {
+        if (!blueprint_object_ids.includes(object_id)) {
+          print(`  ❌ Reference to inexistant object id "${object_id}"`);
+          return false;
+        }
+      }
+
+      globalThis.workbench = {
+        window,
+        application,
+        builder,
+        template,
+        resolve(path) {
+          return demo_dir.resolve_relative_path(path).get_uri();
+        },
+        preview() {},
+      };
+
+      await import(`file://${file_typescript.get_path()}`);
+      print("  ✅ runs");
+
+      await lsp_clients.typescript._notify("textDocument/didClose", {
+        textDocument: {
+          uri,
+        },
+      });
+    }
+
     const file_vala = demo_dir.get_child("main.vala");
     if (file_vala.query_exists(null)) {
       print(`  ${file_vala.get_path()}`);

src/langs/css/CssDocument.js

@@ -25,7 +25,7 @@ export class CssDocument extends Document {
       },
     });
 
-    // Biome doesn't support diff - it just returns one edit
+    // GTKCssLanguageServer doesn't support diff - it just returns one edit
     // we don't want to loose the cursor position so we use this
     const state = this.code_view.saveState();
     applyTextEdits(text_edits, this.buffer);

src/langs/javascript/biome.json

@@ -12,7 +12,8 @@
       "recommended": false,
       "correctness": {
         "noUndeclaredVariables": "error",
-        "noUnusedVariables": "warn"
+        "noUnusedVariables": "warn",
+        "noUnusedImports": "warn"
       }
     }
   }