Skip to content

Commit f656dbb

Browse files
wsdwsd0829nguyenhuy
authored andcommitted
Guard photo library with macro for tests (TextureGroup#1147)
* fix SIMULATE_WEB_RESPONSE not imported TextureGroup#449 * Fix to make rangeMode update in right time * remove uncessary assert * Fix collection cell editing bug for iOS 9 & 10 * Revert "Fix collection cell editing bug for iOS 9 & 10" This reverts commit 06e18a1. * Only test when photo library is enabled. It will fail to build if photo library is disabled cause the test is depending on it. * Add ChangeLog.
1 parent 5dd5611 commit f656dbb

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
## master
22
* Add your own contributions to the next release on the line below this with your name.
3+
- [ASPhotosFrameworkImageRequestTests] Guard photo library with macro for tests. [Max Wang](https://github.com/wsdwsd0829). [#1147](https://github.com/TextureGroup/Texture/pull/1147)
34
- [ASDisplayNode] Do not cancel display when in exit hierarchy but let interface state changing to handle it. [Max Wang](https://github.com/wsdwsd0829). [#1110](https://github.com/TextureGroup/Texture/pull/1110)
45
- [Breaking][ASDisplayNode] Make interface state delegate protocol required. [Max Wang](https://github.com/wsdwsd0829). [#1112](https://github.com/TextureGroup/Texture/pull/1112)
56
- [ASCollectionView] Fix reording of cells manually for iOS 9 & 10. [Max Wang](https://github.com/wsdwsd0829). [#1081](https://github.com/TextureGroup/Texture/pull/1081)

Tests/ASPhotosFrameworkImageRequestTests.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
// Licensed under Apache 2.0: http://www.apache.org/licenses/LICENSE-2.0
88
//
99

10+
#if AS_USE_PHOTOS
11+
1012
#import <XCTest/XCTest.h>
1113
#import <AsyncDisplayKit/ASPhotosFrameworkImageRequest.h>
1214

@@ -59,3 +61,5 @@ - (void)testThatCopyingWorks
5961
}
6062

6163
@end
64+
65+
#endif

0 commit comments

Comments
 (0)