Compostion and checks don't flag unresolvable types

[YassineElbouchaibi]

Component(s)

composition

Component version

The one included in the upstream components versions below.

wgc version

0.93.2

controlplane version

0.163.0

router version

0.252.1

What happened?

Description

Compositions and Checks don't flag nor fail on cases where a type is unresolvable. Here is an example of what I mean:

Products Subgraph

type Product @key(fields: "sku") {
   sku: String!
   price: Float
   displayName: String
   ...
}

Carts Subgraph

type Cart {
   id: String!
   cartRows: [CartRow!]!
}

type CartRow {
   id: String!
   qty: Int
   product: Product
   ...
}

type Product @key(fields: "sku", resolvable: false) {
   sku: String! @external
}

In the example above, the Carts subgraph definition of Product is clearly wrong as Product is unresolvable and yet none of it's fields are provided as they are all marked as external.

Currently the composition and checks don't flag it and later the router fails with an internal error:

validation failed: internal: astvalidation selection set on path query.Cart.cartRows.product is empty\n\t* printOperation: validation failed: external: Cannot query field \"sku\" on type \"Query\".

The expected behavior would be for this to be caught at check and publish time through composition failure.

[github-actions]

WunderGraph commits fully to Open Source and we want to make sure that we can help you as fast as possible.
The roadmap is driven by our customers and we have to prioritize issues that are important to them.
You can influence the priority by becoming a customer. Please contact us here.

[Aenimus]

Hi @YassineElbouchaibi,

You're correct that this should be caught by composition. This is a known issue where an entity is defined with keys, but at least one of the key fields is defined "true @external" (by "true" I mean not resolvable in that graph ever, as opposed to other possible meanings of the "@external" directive).

We do plan to fix this, but there is currently no ETA.

Thanks,

The WunderGraph Team.