Skip to content

Commit 68a6efc

Browse files
committed
fix when do cancel
1 parent 077df79 commit 68a6efc

File tree

2 files changed

+13
-28
lines changed

2 files changed

+13
-28
lines changed

adminlteui/filters.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def __init__(self, field, request, params, model, model_admin, field_path):
4848
_("Invalid date for '%(field_name)s' field range filter") % {
4949
'field_name': field.verbose_name})
5050
else:
51-
self.lookup_val = None
51+
self.lookup_val = ''
5252

5353
super().__init__(field, request, params, model, model_admin, field_path)
5454

adminlteui/templates/adminlte/date_range_filter.html

Lines changed: 12 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33

44
<div class="form-group" style="margin-bottom: 5px;">
55
<button id="id_filter_{{ field_name }}" type="button" class="btn btn-default pull-right"><span>{{ title }} </span><i class="fa fa-caret-down"></i></button>
6-
<input id="id_filter_{{ field_name }}__gte" hidden name="{{ field_name }}__gte" type="text">
7-
<input id="id_filter_{{ field_name }}__lte" hidden name="{{ field_name }}__lte" type="text">
6+
<input id="id_filter_{{ field_name }}__gte" hidden type="text">
7+
<input id="id_filter_{{ field_name }}__lte" hidden type="text">
88

99
<script>
1010
$(document).ready(function () {
@@ -23,9 +23,9 @@
2323
format: '{{ choices.0.date_format }}',
2424
applyLabel: '{% trans "Apply" %}',
2525
cancelLabel: '{% trans "Cancel" %}',
26-
customRangeLabel: '{% trans "CustomRangeLabel" %}'
26+
customRangeLabel: '{% trans "Custom Range" %}'
2727
},
28-
ranges : {
28+
ranges: {
2929
'{% trans "Today" %}' : [moment(), moment()],
3030
'{% trans "Yesterday" %}' : [moment().subtract(1, 'days'), moment().subtract(1, 'days')],
3131
'{% trans "Last 7 Days" %}' : [moment().subtract(6, 'days'), moment()],
@@ -43,39 +43,24 @@
4343
// act on date range selection via widget
4444
$drp_input.on('apply.daterangepicker', function(ev, picker) {
4545
$drp_input.find('span').html(picker.startDate.format('{{ choices.0.date_format }}') + ' - ' + picker.endDate.format('{{ choices.0.date_format }}') + ' ')
46-
$('#id_filter_{{ field_name }}__gte').val(picker.startDate.format('YYYY-MM-DD'));
47-
$('#id_filter_{{ field_name }}__lte').val(picker.endDate.format('YYYY-MM-DD'));
46+
$('#id_filter_{{ field_name }}__gte').attr('name', '{{ field_name }}__gte').val(picker.startDate.format('YYYY-MM-DD'));
47+
$('#id_filter_{{ field_name }}__lte').attr('name', '{{ field_name }}__lte').val(picker.endDate.format('YYYY-MM-DD'));
4848
});
4949
$drp_input.on('cancel.daterangepicker', function(ev, picker) {
5050
$drp_input.find('span').html('{{ title }}' + ' ')
51-
$('#id_filter_{{ field_name }}__gte').val('');
52-
$('#id_filter_{{ field_name }}__lte').val('');
53-
});
54-
// act on manual date range edit
55-
$drp_input.on('change', function(ev) {
56-
var range = $(this).val();
57-
if (range !== "") {
58-
var vals = range.split(' - ');
59-
if (vals.length == 2) {
60-
$('#id_filter_{{ field_name }}__gte').val(moment(vals[0], 'L').format('YYYY-MM-DD'));
61-
$('#id_filter_{{ field_name }}__lte').val(moment(vals[1], 'L').format('YYYY-MM-DD'));
62-
}
63-
} else {
64-
$('#id_filter_{{ field_name }}__gte').val('');
65-
$('#id_filter_{{ field_name }}__lte').val('');
66-
$drp_input.find('span').html('{{ title }}' + ' ')
67-
}
51+
$('#id_filter_{{ field_name }}__gte').attr('name', '').val('');
52+
$('#id_filter_{{ field_name }}__lte').attr('name', '').val('');
6853
});
6954
// set initial value
7055
var range = "{{ choices.0.value }}";
71-
if (range != "") {
56+
if (range !== "") {
7257
var vals = range.split(' - ');
73-
if (vals.length == 2) {
58+
if (vals.length === 2) {
7459
var picker = $drp_input.data('daterangepicker');
7560
picker.setStartDate(moment(vals[0], 'YYYY-MM-DD'));
7661
picker.setEndDate(moment(vals[1], 'YYYY-MM-DD'));
77-
$('#id_filter_{{ field_name }}__gte').val(vals[0]);
78-
$('#id_filter_{{ field_name }}__lte').val(vals[1]);
62+
$('#id_filter_{{ field_name }}__gte').attr('name', '{{ field_name }}__gte').val(vals[0]);
63+
$('#id_filter_{{ field_name }}__lte').attr('name', '{{ field_name }}__lte').val(vals[1]);
7964
$drp_input.find('span').html((moment(vals[0], 'YYYY-MM-DD').format('{{ choices.0.date_format }}') + ' - ' + moment(vals[1], 'YYYY-MM-DD').format('{{ choices.0.date_format }}') + ' '));
8065
}
8166
}

0 commit comments

Comments
 (0)