Don't expect a failure in every propertyCheck call

If a test contains multiple calls to propertyCheck, having a fixed seed will no longer expect every call to raise at least one issue.

Author: x-sheep

Sources/PropertyBased/FixedSeedTrait.swift

@@ -23,7 +23,7 @@ public struct FixedSeedTrait: TestTrait, TestScoping {
     @TaskLocal
     static var fixedRandom: (rng: Xoshiro, location: SourceLocation)?
 
-    public func provideScope(for test: Test, testCase: Test.Case?, performing function: () async throws -> Void) async throws {
+    public func provideScope(for test: Test, testCase: Test.Case?, performing function: () async throws -> Void) async {
         if let existing = Self.fixedRandom {
             Issue.record("Two different fixed seeds are used in the same test.", sourceLocation: existing.location)
             return
@@ -34,8 +34,14 @@ public struct FixedSeedTrait: TestTrait, TestScoping {
             return
         }
 
-        try await Self.$fixedRandom.withValue((rng, location: sourceLocation)) {
-            try await function()
+        let foundIssues = await countIssues {
+            try await Self.$fixedRandom.withValue((rng, location: sourceLocation)) {
+                try await function()
+            }
+        }
+        
+        if foundIssues == 0 {
+            Issue.record("A fixed seed was used, but no expectation failure occured. The property was not tested fully.", sourceLocation: sourceLocation)
         }
     }
 }

Sources/PropertyBased/IssueCounting.swift

@@ -7,16 +7,16 @@
 
 import Testing
 
-func countIssues(isolation: isolated (any Actor)?, perform: () async throws -> Void) async -> Int {
+func countIssues(isolation: isolated (any Actor)? = #isolation, perform: () async throws -> Void) async -> Int {
     let found = Mutex(0)
-
+    
     // This is currently the only way to get a callback whenever an issue is found within a block.
     try? await withKnownIssue(isIntermittent: true, isolation: isolation) {
         try await perform()
     } matching: { _ in
         found.withLock { $0 += 1 }
         return false
     }
-
+    
     return found.withLock { $0 }
 }

Sources/PropertyBased/PropertyCheck.swift

@@ -111,9 +111,5 @@ public func propertyCheck<each Value>(isolation: isolated (any Actor)? = #isolat
             }
             return
         }
-        
-        if foundIssues == 0, let seedLocation = fixedRng?.location {
-            Issue.record("A fixed seed was used, but no expectation failure occured. The property was not tested fully.", sourceLocation: seedLocation)
-        }
     }
 }

Tests/PropertyBasedTests/FixedSeedTests.swift

@@ -15,7 +15,7 @@ import Gen
         let scope = try #require(trait.scopeProvider(for: Test.current!, testCase: Test.Case.current))
 
         let issues = await gatherIssues {
-            try await scope.provideScope(for: Test.current!, testCase: Test.Case.current) {
+            await scope.provideScope(for: Test.current!, testCase: Test.Case.current) {
                 try #require(Bool(false), "block must not be called")
             }
         }
@@ -30,8 +30,8 @@ import Gen
         let trait2 = FixedSeedTrait.fixedSeed("I9kE/glCt1MIxbFsddPUSiKFAAJBGKPHSre93c+Wz9E=")
 
         let issues = await gatherIssues {
-            try await trait1.provideScope(for: Test.current!, testCase: Test.Case.current) {
-                try await trait2.provideScope(for: Test.current!, testCase: Test.Case.current) {
+            await trait1.provideScope(for: Test.current!, testCase: Test.Case.current) {
+                await trait2.provideScope(for: Test.current!, testCase: Test.Case.current) {
                     try #require(Bool(false), "block must not be called")
                 }
             }
@@ -45,7 +45,7 @@ import Gen
     @Test func testIdenticalInputs() async throws {
         let trait = FixedSeedTrait.fixedSeed("4tPCyvymNncnc+napVCI0T4Jc6IYw1lXOQbXlIqyHck=")
         let issues = await gatherIssues {
-            try await trait.provideScope(for: Test.current!, testCase: Test.Case.current) {
+            await trait.provideScope(for: Test.current!, testCase: Test.Case.current) {
                 await propertyCheck(input: .int(in: 0...1000000)) { n in
                     #expect(n == 480813)
                 }