xva export import tests #367
Open
+238
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glehmann
changed the base branch from
gln/coalesce
to
gln/migration-integrity
rzr
reviewed
Nov 28, 2025
| vm.export(xva_path, compression) | ||
| # check that the zero blocks are not part of the result. Most of the data is from the random stream, so | ||
| # compression has little effect. We just check the result is between 500 and 700 MiB | ||
| size_mb = int(vm.host.ssh(f'du -sm {xva_path}').split()[0]) |
There was a problem hiding this comment.
du may not reflect the actual size , or maybe you need to use --apparent-size
rzr
reviewed
Nov 28, 2025
| # check that the zero blocks are not part of the result. Most of the data is from the random stream, so | ||
| # compression has little effect. We just check the result is between 500 and 700 MiB | ||
| size_mb = int(vm.host.ssh(f'du -sm {xva_path}').split()[0]) | ||
| assert 500 < size_mb < 700, f"unexpected xva size: {size_mb}" |
There was a problem hiding this comment.
this looks empirical to me, there is no guarantee is there ?
well since the random is controlled, it should be ok
rzr
reviewed
Nov 28, 2025
| imported_vm = None | ||
| try: | ||
| vm.export(xva_path, compression) | ||
| # check that the zero blocks are not part of the result. Most of the data is from the random stream, so |
There was a problem hiding this comment.
Suggested change
| # check that the zero blocks are not part of the result. Most of the data is from the random stream, so | |
| # check that the zero blocks are not part of the result. | |
| # Most of the data is from the pseudo-random stream, so |
rzr
reviewed
Nov 28, 2025
| imported_vm = vm.host.import_vm(xva_path, vm.vdis[0].sr.uuid) | ||
| imported_vm.start() | ||
| imported_vm.wait_for_vm_running_and_ssh_up() | ||
| imported_vm.ssh("randstream validate -v --expected-checksum 24e905d6 /root/data") |
There was a problem hiding this comment.
would make a constant for 24e905d6 and 500MiB
rzr
reviewed
Nov 28, 2025
|
|
||
| @pytest.mark.small_vm | ||
| @pytest.mark.parametrize("compression", ["none", "gzip", "zstd"]) | ||
| def test_xva_export_import(self, vm_on_lvm_sr: VM, compression): |
rzr
reviewed
Nov 28, 2025
|
|
||
| @pytest.fixture(scope='package') | ||
| def nfs4_sr(host, nfs4_device_config): | ||
| def nfs4_sr(host, image_format: str, nfs4_device_config): |
There was a problem hiding this comment.
i would put this extra param at the end and set a default value
rzr
reviewed
Nov 28, 2025
rzr
left a comment
rzr
left a comment
There was a problem hiding this comment.
lgtm but I see lot of duplicated code, but Is the original intend to make tests "self sufficient" ?
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/xva-export-integrity
branch
from
04dc842 to
40b31bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.