fix: parsing logic error and update dependency @xmldom/xmldom to ^0.9.8 (#1044)

* fix(deps): update dependency @xmldom/xmldom to ^0.9.8

* Update error api

* Fixed a parsing logic error

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Damjan Cvetko <damjan.cvetko@gmail.com>

Author: renovate[bot]

package-lock.json

@@ -45,7 +45,7 @@
   "dependencies": {
     "@vscode/debugadapter": "^1.68.0",
     "@vscode/debugprotocol": "^1.68.0",
-    "@xmldom/xmldom": "^0.8.4",
+    "@xmldom/xmldom": "^0.9.8",
     "buffer-crc32": "^1.0.0",
     "dotenv": "^17.2.1",
     "file-url": "^3.0.0",

package.json

@@ -92,21 +92,18 @@ export class DbgpConnection extends EventEmitter {
                 // append the last piece of the response
                 const lastResponsePiece = data.slice(0, this._dataLength - this._chunksDataLength)
                 this._chunks.push(lastResponsePiece)
-                this._chunksDataLength += data.length
+                this._chunksDataLength += lastResponsePiece.length
                 const response = Buffer.concat(this._chunks, this._chunksDataLength)
                 // call response handler
                 const xml = iconv.decode(response, ENCODING)
                 const parser = new DOMParser({
-                    errorHandler: {
-                        warning: warning => {
-                            this.emit('warning', warning)
-                        },
-                        error: error => {
-                            this.emit('error', error instanceof Error ? error : new Error(error as string))
-                        },
-                        fatalError: error => {
-                            this.emit('error', error instanceof Error ? error : new Error(error as string))
-                        },
+                    onError: (level, msg) => {
+                        if (level === 'warning') {
+                            this.emit('warning', msg)
+                        }
+                        if (level === 'error' || level === 'fatalError') {
+                            this.emit('error', new Error(msg))
+                        }
                     },
                 })
                 this.emit('log', `-> ${xml.replace(/[\0\n]/g, '')}`)

src/dbgp.ts

@@ -155,10 +155,8 @@ export class ProxyConnect extends EventEmitter {
     /** Parse data from response server and emit the relevant notification. */
     private _responseStrategy(data: Buffer) {
         try {
-            const documentElement = this._parser.parseFromString(
-                decode(data, ENCODING),
-                'application/xml'
-            ).documentElement
+            const documentElement = this._parser.parseFromString(decode(data, ENCODING), 'application/xml')
+                .documentElement!
             const isSuccessful = documentElement.getAttribute('success') === '1'
             const error = documentElement.firstChild
             if (isSuccessful && documentElement.nodeName === 'proxyinit') {