Backport changes so that this can be used in Matterbridge?

[poVoq]

https://github.com/matterbridge/go-xmpp

Is currently used in Matterbridge, but it would be great if a more actively maintained version could be used instead.

I assume there are some smaller changes that could be backported or rather forwardported?

For example: master...matterbridge:go-xmpp:matterbridge2024

Edit: These seem to have no conflicts: master...matterbridge:go-xmpp:matterbridge

[mdosch]

Maybe you can PR the changes. I would also appreciate if the matterbridge people woult directly contribute to the lib.

[poVoq]

Currenty I am away from my PC for a few weeks, so i can't do it.

Generally Matterbridge dev is very stale and it is somewhat likely that some fork will emerge and hopefully not drop the very ill maintained xmpp support.

[selfhoster1312]

Hi, i'm starting to maintain a matterbridge fork (who hopefully may get reunited with uptsream sometime).

The linked fork is not correct according to XEP-0461Message Replies, the reply ID should be:

• when in MUC: XEP-0359 Unique and Stable Stanza IDs's <stanza-id>
• when in private chat: XEP-0359 origin-id when present, the message's id otherwise

What is the current support of XEP-0359 and XEP-0461 in go-xmpp? I don't really understand what all the fields in Chat are and when they are populated or not (are the fields "" by default?). is there additional documentation somewhere? An introduction to how structs are parsed from stanzas in this library? Or should i read the code for reference?

[mdosch]

Those XEPs are relatively new compared to the age of this library and I think no one ever added these. Maybe you could contribute this? Like I started contributing to go-xmpp when I needed/wanted some modern auth stuff for my tool that's using this lib. :)

[poVoq]

So am I understanding this correctly that we can't easily backport those changes because they might not be standards conformant, but if they would be made to be standards conformant, then it would likely also require a larger change in Matterbridge itself?

Edit: looks like only collaborators can create PRs here?

[mdosch]

@selfhoster1312
Not sure about the changes to matterbridge as I'm not familiar with their code. However, I pushed a first draft of xep-0359 support. Just have a look if that would be usable for you.

I'm not a ware of a PR limitation ad I have seen several people create PRs. I'll check if I see something I can change, otherwise I'll ask the organization owner.

[mdosch]

@Neustradamus and @mattn
I don't have access to the repo settings, can you please check whether creating PRs is allowed for everyone?

You don't have access to repository options

[mdosch]

Edit: looks like only collaborators can create PRs here?

Can you try again? I have access to the repo settings now and I have not seen any setting preventing PRs.

[poVoq]

No, if I try to make a PR here I get the following error:
Pull request creation failed. Validation failed: must be a collaborator

[mdosch]

Weird, I'll have to check again another time. Did you have a look at my origin-id draft linked earlier?

[mdosch-test]

@poVoq I just created this test account and was able to create a PR: #199
So it looks like you are doing something wrong. :(

[poVoq]

Hmm, maybe because I am trying to create a PR from a repo I am not a collaborator in? I am not so familiar how Github handles these things, but if that isn't allowed, it is a bit odd that I get shown the option to do so.

Edit: odd, that seems to have made the difference.