From e07bb4e895b8f7980e8ce0abd210deef4b2dbdaf Mon Sep 17 00:00:00 2001 From: Josiah Outram Halstead Date: Mon, 22 May 2023 14:02:59 +0100 Subject: [PATCH 1/4] Always capture subprocess stdout --- xonsh_jupyter/kernel.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/xonsh_jupyter/kernel.py b/xonsh_jupyter/kernel.py index b4cb53a..c2b2a48 100644 --- a/xonsh_jupyter/kernel.py +++ b/xonsh_jupyter/kernel.py @@ -491,7 +491,10 @@ def handle_kernel_info_request(self, message, identities): def main(): setup( shell_type=JupyterShell, - env={"PAGER": "cat"}, + env={ + "PAGER": "cat", + "XONSH_CAPTURE_ALWAYS": True, + }, aliases={"less": "cat"}, xontribs=["coreutils"], threadable_predictors={"git": predict_true, "man": predict_true}, From 62f061bc6739374c7a3c1172901088516f9d1959 Mon Sep 17 00:00:00 2001 From: Andy Kipp Date: Tue, 23 May 2023 17:36:02 +0600 Subject: [PATCH 2/4] Update kernel.py --- xonsh_jupyter/kernel.py | 1 + 1 file changed, 1 insertion(+) diff --git a/xonsh_jupyter/kernel.py b/xonsh_jupyter/kernel.py index c2b2a48..22a6ba6 100644 --- a/xonsh_jupyter/kernel.py +++ b/xonsh_jupyter/kernel.py @@ -493,6 +493,7 @@ def main(): shell_type=JupyterShell, env={ "PAGER": "cat", + "AWS_PAGER": "cat", # https://docs.aws.amazon.com/cli/latest/userguide/cli-usage-pagination.html#cli-usage-pagination-awspager "XONSH_CAPTURE_ALWAYS": True, }, aliases={"less": "cat"}, From 56f6dbc62a4f7d7c5a60e83f1292c255950226a9 Mon Sep 17 00:00:00 2001 From: Andy Kipp Date: Tue, 23 May 2023 17:40:40 +0600 Subject: [PATCH 3/4] Update README.md --- README.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/README.md b/README.md index 3fe71f0..7529785 100644 --- a/README.md +++ b/README.md @@ -104,6 +104,12 @@ jupyter notebook 3. The release notes are automatically generated as a draft release after each PR. 4. Create a GitHub release from the draft release against the newly pushed tag +## Known issues + +### Uncaptured stdout + +This kernel uses xonsh with [`$XONSH_CAPTURE_ALWAYS = True`](https://xon.sh/envvars.html#xonsh-capture-always) and some commands that have waiting for user input could be uncaptured. + ## Credits * This package was created with [xontrib cookiecutter template](https://github.com/xonsh/xontrib-cookiecutter). From e07b036276d5a20915264888bd0fbd42a8a5cd58 Mon Sep 17 00:00:00 2001 From: Andy Kipp Date: Tue, 23 May 2023 17:52:42 +0600 Subject: [PATCH 4/4] Update kernel.py --- xonsh_jupyter/kernel.py | 1 - 1 file changed, 1 deletion(-) diff --git a/xonsh_jupyter/kernel.py b/xonsh_jupyter/kernel.py index 22a6ba6..c2b2a48 100644 --- a/xonsh_jupyter/kernel.py +++ b/xonsh_jupyter/kernel.py @@ -493,7 +493,6 @@ def main(): shell_type=JupyterShell, env={ "PAGER": "cat", - "AWS_PAGER": "cat", # https://docs.aws.amazon.com/cli/latest/userguide/cli-usage-pagination.html#cli-usage-pagination-awspager "XONSH_CAPTURE_ALWAYS": True, }, aliases={"less": "cat"},