Emit clone with expressions natively in PHP 8.5+

Author: thekid

ChangeLog.md

@@ -3,6 +3,9 @@ XP Compiler ChangeLog
 
 ## ?.?.? / ????-??-??
 
+* Changed PHP 8.5 emitter to emit *clone with* expressions natively now
+  that the RFC has been implemented
+  (@thekid)
 * Fixed the warning *Using null as an array offset is deprecated, use an
   empty string instead* in PHP 8.5+
   (@thekid)

src/main/php/lang/ast/emit/PHP85.class.php

@@ -19,7 +19,7 @@
  * @see  https://wiki.php.net/rfc#php_85
  */
 class PHP85 extends PHP {
-  use RewriteBlockLambdaExpressions, RewriteCallableClone, RewriteCloneWith; // TODO: Remove once PR is merged!
+  use RewriteBlockLambdaExpressions, RewriteCallableClone;
 
   public $targetVersion= 80500;
 

src/test/php/lang/ast/unittest/emit/PHP85Test.class.php

@@ -23,4 +23,12 @@ public function nullsafepipe_operator() {
       $this->emit('"test" ?|> strtoupper(...);')
     );
   }
+
+  #[Test]
+  public function clone_with() {
+    Assert::equals(
+      'clone($this,["name"=>strtoupper($this->name),]);',
+      $this->emit('clone($this, ["name" => strtoupper($this->name)]);')
+    );
+  }
 }