[Bug?]: Incorrect FS return type under PnP #6890
Description
Self-service
- I'd be willing to implement a fix
Describe the bug
It seems the package image-size does not behave correctly under PnP, even if it's unplugged.
This commit at least fixes some of the errors, but not all of them.
To reproduce
Clone https://github.com/dafitius/glaciermodding.org
git checkout e16758f4809889f1d8c32418cad7198636e44c0a
yarn install
yarn build
Environment
System:
OS: macOS 15.6.1
CPU: (8) arm64 Apple M3
Binaries:
Node: 20.18.1 - /private/var/folders/93/c_bqvsps47l1hyygdwdcvfnc0000gn/T/xfs-a632e2f8/node
Yarn: 1.22.22 - /private/var/folders/93/c_bqvsps47l1hyygdwdcvfnc0000gn/T/xfs-a632e2f8/yarn
npm: 10.8.2 - ~/.nvm/versions/node/v20.18.1/bin/npm
pnpm: 9.15.3 - ~/.nvm/versions/node/v20.18.1/bin/pnpmAdditional context
TypeError: The "buffer" argument must be an instance of Buffer, TypedArray, or DataView. Received an instance of ArrayBuffer
at Object.read (node:fs:635:3)
at /home/runner/work/glaciermodding.org/glaciermodding.org/.pnp.cjs:21120:19
at new Promise (<anonymous>)
at NodeFS.readPromise (/home/runner/work/glaciermodding.org/glaciermodding.org/.pnp.cjs:21119:18)
at ZipOpenFS.readPromise (/home/runner/work/glaciermodding.org/glaciermodding.org/.pnp.cjs:21590:32)
at VirtualFS.readPromise (/home/runner/work/glaciermodding.org/glaciermodding.org/.pnp.cjs:20831:30)
at PosixFS.readPromise (/home/runner/work/glaciermodding.org/glaciermodding.org/.pnp.cjs:20831:30)
at NodePathFS.readPromise (/home/runner/work/glaciermodding.org/glaciermodding.org/.pnp.cjs:20831:30)
at FileHandle.read (/home/runner/work/glaciermodding.org/glaciermodding.org/.pnp.cjs:22543:45)
at /home/runner/work/glaciermodding.org/glaciermodding.org/.yarn/cache/image-size-npm-2.0.2-43abbcfb5c-d15203279f.zip/node_modules/image-size/dist/fromFile.cjs:1039:20
at async Promise.allSettled (index 0)
at async processQueue (/home/runner/work/glaciermodding.org/glaciermodding.org/.yarn/cache/image-size-npm-2.0.2-43abbcfb5c-d15203279f.zip/node_modules/image-size/dist/fromFile.cjs:1047:3) {
code: 'ERR_INVALID_ARG_TYPE'
}