Propagate deadline in SDK components (#27497)

Author: Gazizonoki

ydb/apps/pgwire/pg_ydb_proxy.cpp

@@ -72,7 +72,7 @@ class TPgYdbProxy : public TActor<TPgYdbProxy> {
         NYdb::TDbDriverStatePtr driverState = Connections->GetDriverState(database, {}, {}, {}, {});
 
         NYdb::TRpcRequestSettings rpcSettings;
-        rpcSettings.ClientTimeout = TDuration::Seconds(60);
+        rpcSettings.Deadline = NYdb::TDeadline::AfterDuration(std::chrono::seconds(60));
 
         NYdb::TGRpcConnectionsImpl::RunOnDiscoveryEndpoint<Ydb::Auth::V1::AuthService, Ydb::Auth::LoginRequest, Ydb::Auth::LoginResponse>(
             driverState,

ydb/core/fq/libs/checkpoint_storage/ydb_state_storage.cpp

@@ -699,7 +699,7 @@ TFuture<TStatus> TStateStorage::ListStates(const TContextPtr& context) {
 TExecDataQuerySettings TStateStorage::GetExecDataQuerySettings(ui64 multiplier) {
     return TExecDataQuerySettings()
         .KeepInQueryCache(true)
-        .ClientTimeout(StorageConfig.GetClientTimeout() * multiplier)
+        .ClientTimeout(StorageConfig.GetClientTimeout() == TDuration::Max() ? TDuration::Max() : StorageConfig.GetClientTimeout() * multiplier)
         .OperationTimeout(StorageConfig.GetOperationTimeout() * multiplier)
         .CancelAfter(StorageConfig.GetCancelAfter() * multiplier);
 }

ydb/core/fq/libs/ydb/ydb.cpp

@@ -194,13 +194,15 @@ TExternalStorageSettings::TExternalStorageSettings(const NConfig::TYdbStorageCon
     , UseSsl(config.GetUseSsl())
     , UseLocalMetadataService(config.GetUseLocalMetadataService())
     , IamEndpoint(config.GetIamEndpoint())
-    , ClientTimeout(TDuration::Seconds(config.GetClientTimeoutSec()))
     , OperationTimeout(TDuration::Seconds(config.GetOperationTimeoutSec()))
     , CancelAfter(TDuration::Seconds(config.GetCancelAfterSec()))
 {
     if (config.GetTableClientMaxActiveSessions()) {
         MaxActiveQuerySessions = config.GetTableClientMaxActiveSessions();
     }
+    if (config.GetClientTimeoutSec()) {
+        ClientTimeout = TDuration::Seconds(config.GetClientTimeoutSec());
+    }
 }
 
 TExternalStorageSettings::TExternalStorageSettings(const NKikimrConfig::TStreamingQueriesConfig::TExternalStorageConfig& config)
@@ -213,13 +215,15 @@ TExternalStorageSettings::TExternalStorageSettings(const NKikimrConfig::TStreami
     , UseSsl(config.GetDatabaseConnection().GetUseSsl())
     , UseLocalMetadataService(config.GetDatabaseConnection().GetUseLocalMetadataService())
     , IamEndpoint(config.GetDatabaseConnection().GetIamEndpoint())
-    , ClientTimeout(TDuration::Seconds(config.GetQueryTimeoutSec()))
     , OperationTimeout(TDuration::Seconds(config.GetQueryTimeoutSec()))
     , CancelAfter(TDuration::Seconds(config.GetQueryTimeoutSec()))
 {
     if (config.GetMaxActiveQuerySessions()) {
         MaxActiveQuerySessions = config.GetMaxActiveQuerySessions();
     }
+    if (config.GetQueryTimeoutSec()) {
+        ClientTimeout = TDuration::Seconds(config.GetQueryTimeoutSec());
+    }
 }
 
 TYdbConnection::TYdbConnection(const TExternalStorageSettings& config,

ydb/core/fq/libs/ydb/ydb.h

@@ -42,7 +42,7 @@ class TExternalStorageSettings {
     YDB_ACCESSOR(bool, UseLocalMetadataService, false);
     YDB_ACCESSOR_DEF(TString, IamEndpoint);
     YDB_ACCESSOR(ui64, MaxActiveQuerySessions, 50); // 50 - default in TSessionPoolSettings
-    YDB_ACCESSOR_DEF(TDuration, ClientTimeout);
+    YDB_ACCESSOR(TDuration, ClientTimeout, TDuration::Max());
     YDB_ACCESSOR_DEF(TDuration, OperationTimeout);
     YDB_ACCESSOR_DEF(TDuration, CancelAfter);
 };

ydb/core/grpc_caching/request_data.h

@@ -12,7 +12,7 @@ namespace NKikimr {
 
         NYdbGrpc::TCallMeta FillCallMeta() const {
             NYdbGrpc::TCallMeta callMeta;
-            callMeta.Timeout = DEFAULT_CACHED_GRPC_REQUEST_TIMEOUT;
+            callMeta.Timeout = NYdb::TDeadline::SafeDurationCast(DEFAULT_CACHED_GRPC_REQUEST_TIMEOUT);
             callMeta.Aux.emplace_back(REQUEST_ID_METADATA_NAME, RequestId);
             return callMeta;
         }
@@ -30,7 +30,7 @@ namespace NKikimr {
 
         NYdbGrpc::TCallMeta FillCallMeta() const {
             NYdbGrpc::TCallMeta callMeta;
-            callMeta.Timeout = DEFAULT_CACHED_GRPC_REQUEST_TIMEOUT;
+            callMeta.Timeout = NYdb::TDeadline::SafeDurationCast(DEFAULT_CACHED_GRPC_REQUEST_TIMEOUT);
             callMeta.Aux.emplace_back("authorization", "Bearer " + Ticket);
             return callMeta;
         }

ydb/core/health_check/health_check.cpp

@@ -3843,7 +3843,7 @@ class TNodeCheckRequest : public TActorBootstrapped<TNodeCheckRequest<RequestTyp
             }
         };
         NYdbGrpc::TCallMeta meta;
-        meta.Timeout = Timeout;
+        meta.Timeout = Timeout ? NYdb::TDeadline::SafeDurationCast(Timeout) : NYdb::TDeadline::Duration::max();
         auto service = GRpcClientLow->CreateGRpcServiceConnection<::Ydb::Monitoring::V1::MonitoringService>(config);
         service->DoRequest(request, std::move(responseCb), &Ydb::Monitoring::V1::MonitoringService::Stub::AsyncNodeCheck, meta);
     }

ydb/core/http_proxy/discovery_actor.cpp

@@ -98,7 +98,7 @@ namespace NKikimr::NHttpProxy {
 
     void TDiscoveryActor::MakeGRpcRequest(const TActorContext& ctx) {
         NYdbGrpc::TCallMeta callMeta;
-        callMeta.Timeout = TDuration::Seconds(30);
+        callMeta.Timeout = std::chrono::seconds(30);
         callMeta.Aux.emplace_back("x-ydb-auth-ticket", CredentialsProvider->GetAuthInfo());
         callMeta.Aux.emplace_back("x-ydb-database", Settings.Database);
 

ydb/library/grpc/actor_client/grpc_service_client.h

@@ -86,7 +86,7 @@ class TGrpcServiceClient  {
 
         const TRequestType& request = ev->Get()->Request;
         NYdbGrpc::TCallMeta meta;
-        meta.Timeout = Config.Timeout;
+        meta.Timeout = Config.Timeout ? NYdb::TDeadline::SafeDurationCast(Config.Timeout) : NYdb::TDeadline::Duration::max();
         if (auto token = ev->Get()->Token) {
             if (!AsciiHasPrefixIgnoreCase(token, "Bearer "sv)) {
                 token = "Bearer " + token;

ydb/library/yql/providers/common/token_accessor/client/token_accessor_client.cpp

@@ -70,7 +70,7 @@ class TTokenAccessorCredentialsProvider : public NYdb::ICredentialsProvider {
                     std::move(cb),
                     &TokenAccessorService::Stub::AsyncGetToken,
                     {
-                        {}, {}, RequestTimeout
+                        {}, {}, RequestTimeout ? NYdb::TDeadline::SafeDurationCast(RequestTimeout) : NYdb::TDeadline::Duration::max()
                     },
                     context.get()
                 );

ydb/library/yql/providers/dq/global_worker_manager/service_node_pinger.cpp

@@ -288,7 +288,7 @@ class TServiceNodePinger: public TActor<TServiceNodePinger> {
                 if (!lastPingTime || errors > 1 || oks < 2 || !result.NodeId) {
                     // GRPC ping
                     NYdbGrpc::TCallMeta meta;
-                    meta.Timeout = timeout;
+                    meta.Timeout = NYdb::TDeadline::SafeDurationCast(timeout);
                     result.Connection->DoRequest<Yql::DqsProto::RegisterNodeRequest, Yql::DqsProto::RegisterNodeResponse>(
                         req, [=] (NYdbGrpc::TGrpcStatus&& status, Yql::DqsProto::RegisterNodeResponse&& resp) {
                             if (!status.Ok()) {