From 4c0b3f97c5a711451cf63fadac714cb50d3aeb99 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Bachelier?= Date: Thu, 13 Nov 2014 01:51:20 +0100 Subject: [PATCH] test(hashmap): extract the hashmap fixtures Make tests more robusts as there is a test in Gruntfile and should help the PR #38 --- Gruntfile.js | 3 ++- test/hashes.json | 7 +++++++ test/test.js | 9 +-------- 3 files changed, 10 insertions(+), 9 deletions(-) create mode 100644 test/hashes.json diff --git a/Gruntfile.js b/Gruntfile.js index 0986aa2..117c48e 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -86,8 +86,9 @@ module.exports = function (grunt) { ]); grunt.registerTask('checkSummary', 'Check that summary attribute is correctly created', function () { + var hashes = grunt.file.readJSON('test/hashes.json'); var src = path.normalize('test/fixtures/file.png'); - var expected = path.normalize('test/tmp/file.26365248.png'); + var expected = path.normalize(hashes['test/fixtures/file.png']); assert.equal(grunt.filerev.summary[src], expected); }); }; diff --git a/test/hashes.json b/test/hashes.json new file mode 100644 index 0000000..727a42d --- /dev/null +++ b/test/hashes.json @@ -0,0 +1,7 @@ +{ + "test/fixtures/file.png": "test/tmp/file.26365248.png", + "test/fixtures/cfgfile.png": "test/tmp/cfgfile.da63.png", + "test/fixtures/math.js": "test/tmp/withSourceMaps/math.2f56179e.js", + "test/fixtures/math.js.map": "test/tmp/withSourceMaps/math.2f56179e.js.map", + "test/fixtures/physics.js": "test/tmp/withSourceMaps/physics.14a0a482.js" +} diff --git a/test/test.js b/test/test.js index 1692408..6f99ffe 100644 --- a/test/test.js +++ b/test/test.js @@ -2,13 +2,7 @@ var fs = require('fs'); var assert = require('assert'); -var hashes = { - 'test/fixtures/file.png' : 'test/tmp/file.26365248.png', - 'test/fixtures/cfgfile.png' : 'test/tmp/cfgfile.da63.png', - 'test/fixtures/math.js' : 'test/tmp/withSourceMaps/math.2f56179e.js', - 'test/fixtures/math.js.map' : 'test/tmp/withSourceMaps/math.2f56179e.js.map', - 'test/fixtures/physics.js' : 'test/tmp/withSourceMaps/physics.14a0a482.js' -}; +var hashes = require('./hashes.json'); it('should revision files based on content', function () { var file = 'test/fixtures/file.png'; @@ -51,4 +45,3 @@ it('should revision .js file ok without any .map', function () { var revisioned = fs.statSync(hashes[file]).size; assert(revisioned === original); }); -