Merge pull request #89 from pypeclub/hotfix/nuke-lib

Nuke Lib and Create fixes

Author: mkolar

avalon/nuke/lib.py

@@ -20,17 +20,25 @@ def maintained_selection():
     """
     nodes = nuke.allNodes()
     previous_selection = nuke.selectedNodes()
+
+    # deselect all nodes
+    reset_selection()
+
     try:
+        # do the operation
         yield
     finally:
         # unselect all selection in case there is some
         reset_selection()
         # and select all previously selected nodes
         if previous_selection:
-            for n in nodes:
-                if n.name() not in previous_selection:
-                    continue
-                n['selected'].setValue(True)
+            try:
+                for n in nodes:
+                    if n not in previous_selection:
+                        continue
+                    n['selected'].setValue(True)
+            except ValueError as e:
+                log.warning(e)
 
 
 def reset_selection():
@@ -48,8 +56,11 @@ def select_nodes(nodes):
     """
     assert isinstance(nodes, (list, tuple)), "nodes has to be list or tuple"
 
-    for node in nodes:
-        node['selected'].setValue(True)
+    try:
+        for node in nodes:
+            node['selected'].setValue(True)
+    except ValueError as e:
+        log.warning(e)
 
 
 def add_publish_knob(node):
@@ -197,6 +208,20 @@ def get_avalon_knob_data(node, prefix="ak:"):
 
     return data
 
+def check_subsetname_exists(nodes, subset_name):
+    """
+    Checking if node is not already created to secure there is no duplicity
+
+    Arguments:
+        nodes (list): list of nuke.Node objects
+        subset_name (str): name we try to find
+
+    Returns:
+        bool: True of False
+    """
+    return next((True for n in nodes
+    if subset_name in get_avalon_knob_data(n,
+        ["avalon:", "ak:"]).get("subset", "")), False)
 
 def imprint(node, data):
     """Adding `Avalon data` into a node's Avalon Tab/Avalon knob

avalon/nuke/pipeline.py

@@ -165,6 +165,18 @@ class Creator(api.Creator):
     """
     node_color = "0xdfea5dff"
 
+    def __init__(self, *args, **kwargs):
+        super(Creator, self).__init__(*args, **kwargs)
+        # make sure no duplicity of subsets are in workfile
+        if lib.check_subsetname_exists(
+                nuke.allNodes(),
+                self.data["subset"]):
+            msg = "The subset name `{0}` is already used on a node in" \
+                  "this workfile.".format(self.data["subset"])
+            self.log.error(msg + '\n\nPlease use other subset name!')
+            raise NameError("`{0}: {1}".format(__name__, msg))
+        return
+
     def process(self):
         from nukescripts import autoBackdrop
         nodes = list()
@@ -179,6 +191,7 @@ def process(self):
 
             elif len(nodes) >= 2:
                 bckd_node = autoBackdrop()
+                bckd_node["name"].setValue("{}_BDN".format(self.name))
                 bckd_node["tile_color"].setValue(int(self.node_color, 16))
                 bckd_node["note_font_size"].setValue(24)
                 bckd_node["label"].setValue("[{}]".format(self.name))
@@ -192,6 +205,7 @@ def process(self):
                 return
         else:
             bckd_node = autoBackdrop()
+            bckd_node["name"].setValue("{}_BDN".format(self.name))
             bckd_node["tile_color"].setValue(int(self.node_color, 16))
             bckd_node["note_font_size"].setValue(24)
             bckd_node["label"].setValue("[{}]".format(self.name))

avalon/pipeline.py

@@ -898,8 +898,8 @@ def create(name, asset, family, options=None, data=None):
             with host.maintained_selection():
                 print("Running %s" % plugin)
                 instance = plugin.process()
-        except Exception as e:
-            log.warning(e)
+        except Exception:
+            log.warning(traceback.format_exc())
             continue
         plugins.append(plugin)