Skip to content

Commit 1fb788a

Browse files
author
Martin Linkhorst
committed
domain
1 parent 141bf12 commit 1fb788a

File tree

5 files changed

+3
-17
lines changed

5 files changed

+3
-17
lines changed

cmd/e2e/README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ The following environment variables should be set:
44

55
1. `E2E_NAMESPACE` is the namespace where the tests should be run.
66
2. `CLUSTER_DOMAIN` is the DNS domain managed in which ingresses should be created
7-
3. `CLUSTER_DOMAIN_INTERNAL` is the internal DNS domain managed in which ingresses should be created
87
4. `CONTROLLER_ID` is set so that all stacks are only managed by the controller being currently tested.
98
5. `KUBECONFIG` with the path to the kubeconfig file
109

@@ -36,10 +35,10 @@ make
3635
--enable-pcs-support --enable-traffic-segments --controller-id=foo \
3736
--sync-ingress-annotation=example.org/i-haz-synchronize \
3837
--sync-ingress-annotation=teapot.org/the-best \
39-
--cluster-domain=${CLUSTER_DOMAIN} --cluster-domain=${CLUSTER_DOMAIN_INTERNAL}
38+
--cluster-domain=${CLUSTER_DOMAIN}
4039
```
4140
4. rebuild e2e test and run e2e tests in `foo` namespace
4241
```
4342
rm -f build/e2e; make build/e2e
44-
CLUSTER_DOMAIN=example.org CLUSTER_DOMAIN_INTERNAL=ingress.cluster.local CLUSTER_NAME=example E2E_NAMESPACE=foo CONTROLLER_ID=foo KUBECONFIG=$HOME/.kube/config ./build/e2e -test.v #-test.run=TestTrafficSwitch
43+
CLUSTER_DOMAIN=example.org CLUSTER_NAME=example E2E_NAMESPACE=foo CONTROLLER_ID=foo KUBECONFIG=$HOME/.kube/config ./build/e2e -test.v #-test.run=TestTrafficSwitch
4544
```

cmd/e2e/test_environment.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@ var (
2424
kubernetesClient, stacksetClient, routegroupClient = createClients()
2525
namespace = requiredEnvar("E2E_NAMESPACE")
2626
clusterDomain = requiredEnvar("CLUSTER_DOMAIN")
27-
clusterDomainInternal = requiredEnvar("CLUSTER_DOMAIN_INTERNAL")
28-
clusterDomains = []string{clusterDomain, clusterDomainInternal}
27+
clusterDomains = []string{clusterDomain}
2928
controllerId = os.Getenv("CONTROLLER_ID")
3029
waitTimeout time.Duration
3130
trafficSwitchWaitTimeout time.Duration

delivery.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,6 @@ pipeline:
5555
- name: CONTROLLER_ID
5656
value: "#{CDP_BUILD_VERSION}"
5757
- name: CLUSTER_DOMAIN
58-
value: stups-test.zalan.do
59-
- name: CLUSTER_DOMAIN_INTERNAL
6058
value: ingress.cluster.local
6159
end2end_tests:
6260
metadata:
@@ -74,8 +72,6 @@ pipeline:
7472
- name: "CONTROLLER_ID"
7573
value: "#{CDP_BUILD_VERSION}"
7674
- name: CLUSTER_DOMAIN
77-
value: stups-test.zalan.do
78-
- name: CLUSTER_DOMAIN_INTERNAL
7975
value: ingress.cluster.local
8076
- name: "E2E_NAMESPACE"
8177
valueFrom:

e2e/apply/deployment.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ spec:
2626
- "--namespace={{{CDP_DEPLOYMENT_ID}}}"
2727
- "--controller-id={{{CONTROLLER_ID}}}"
2828
- "--cluster-domain={{{CLUSTER_DOMAIN}}}"
29-
- "--cluster-domain={{{CLUSTER_DOMAIN_INTERNAL}}}"
3029
- "--enable-configmap-support"
3130
- "--enable-secret-support"
3231
- "--enable-routegroup-support"

e2e/run_e2e.sh

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ set -euf -o pipefail
44
shopt -s nullglob
55

66
CLUSTER_DOMAIN=${CLUSTER_DOMAIN:-""}
7-
CLUSTER_DOMAIN_INTERNAL=${CLUSTER_DOMAIN_INTERNAL:-""}
87
CLUSTER_NAME=${CLUSTER_NAME:-""}
98
# Set TEST_NAME to run a single test
109
# eg.: TEST_NAME=TestIngressToRouteGroupSwitch ./e2e/run_e2e.sh
@@ -17,11 +16,6 @@ if [[ -z "${CLUSTER_DOMAIN}" ]]; then
1716
exit 0
1817
fi
1918

20-
if [[ -z "${CLUSTER_DOMAIN_INTERNAL}" ]]; then
21-
echo "Please specify the cluster domain via CLUSTER_DOMAIN_INTERNAL."
22-
exit 0
23-
fi
24-
2519
if [[ -z "${CLUSTER_NAME}" ]]; then
2620
echo "Please specify the name of the cluster via CLUSTER_NAME."
2721
exit 0
@@ -57,7 +51,6 @@ command $sscPath --apiserver=http://127.0.0.1:8001 \
5751
--enable-pcs-support \
5852
--enable-routegroup-support \
5953
--cluster-domain=${CLUSTER_DOMAIN} \
60-
--cluster-domain=${CLUSTER_DOMAIN_INTERNAL} \
6154
--controller-id=$CONTROLLER_ID 2>$controllerLog&
6255

6356
# Create the Kubernetes namespace to be used for this test run.

0 commit comments

Comments
 (0)