fix: update availability zone references in VPC endpoint modules

Signed-off-by: Ghislain Cheng <ghislain.cheng@zama.ai>

Author: maxnovawind

modules/vpc-endpoint-consumer/main.tf

@@ -51,7 +51,7 @@ resource "aws_vpc_endpoint" "party_interface_endpoints" {
   vpc_endpoint_type = "Interface"
   subnet_ids = length(coalesce(each.value.availability_zones, [])) > 0 && var.cluster_name != null ? [
     for subnet_id, subnet in data.aws_subnet.cluster_subnets : subnet_id
-    if subnet.map_public_ip_on_launch == false && contains(subnet.availability_zone, each.value.availability_zones)
+    if subnet.map_public_ip_on_launch == false && contains(each.value.availability_zones, subnet.availability_zone_id)
   ] : local.subnet_ids
   security_group_ids = local.security_group_ids
   service_region     = each.value.region

modules/vpc-endpoint-provider/main.tf

@@ -130,7 +130,7 @@ data "aws_subnet" "nlb_subnet" {
 
 # Get all availability zones from the NLB subnets
 locals {
-  availability_zones = [for subnet in data.aws_subnet.nlb_subnet : subnet.availability_zone]
+  availability_zones = [for subnet in data.aws_subnet.nlb_subnet : subnet.availability_zone_id]
 }
 
 # **************************************************************