From a037a40b793fbb16a4050ec87b2d1c1f93f93208 Mon Sep 17 00:00:00 2001 From: 43z708 Date: Fri, 19 Sep 2025 17:17:14 +0900 Subject: [PATCH 1/3] feat(mpc-party): Improved RDS configuration by adding variables and removing unnecessary variables. --- examples/mpc-party/main.tf | 3 ++- examples/mpc-party/terraform.tfvars.example | 1 + examples/mpc-party/variables.tf | 12 ------------ 3 files changed, 3 insertions(+), 13 deletions(-) diff --git a/examples/mpc-party/main.tf b/examples/mpc-party/main.tf index 6e814fd..71c1258 100644 --- a/examples/mpc-party/main.tf +++ b/examples/mpc-party/main.tf @@ -65,6 +65,7 @@ module "mpc_party" { kms_image_attestation_sha = var.kms_image_attestation_sha kms_deletion_window_in_days = var.kms_deletion_window_in_days + nodegroup_source_security_group_ids = var.nodegroup_source_security_group_ids nodegroup_additional_security_group_ids = var.nodegroup_additional_security_group_ids nodegroup_enable_ssm_managed_instance = var.nodegroup_enable_ssm_managed_instance nodegroup_use_latest_ami_release_version = var.nodegroup_use_latest_ami_release_version @@ -79,6 +80,7 @@ module "mpc_party" { # RDS Configuration enable_rds = var.enable_rds rds_db_name = var.rds_db_name + rds_prefix = var.rds_prefix rds_create_monitoring_role = var.rds_create_monitoring_role rds_manage_master_user_password = var.rds_manage_master_user_password rds_username = var.rds_username @@ -103,7 +105,6 @@ module "mpc_party" { rds_k8s_secret_namespace = var.rds_k8s_secret_namespace rds_allowed_cidr_blocks = var.rds_allowed_cidr_blocks rds_vpc_id = var.rds_vpc_id - rds_subnet_ids = var.rds_subnet_ids rds_deletion_protection = var.rds_deletion_protection # Tagging diff --git a/examples/mpc-party/terraform.tfvars.example b/examples/mpc-party/terraform.tfvars.example index a9354f9..a4ba7ec 100644 --- a/examples/mpc-party/terraform.tfvars.example +++ b/examples/mpc-party/terraform.tfvars.example @@ -6,6 +6,7 @@ aws_region = "eu-west-1" enable_region_validation = false # MPC Party Configuration +party_id = 1 party_name = "mpc-party-2" environment = "dev" diff --git a/examples/mpc-party/variables.tf b/examples/mpc-party/variables.tf index 83eaf30..efee374 100644 --- a/examples/mpc-party/variables.tf +++ b/examples/mpc-party/variables.tf @@ -117,12 +117,6 @@ variable "kubeconfig_context" { default = null } -variable "eks_cluster_name" { - description = "EKS cluster name for automatic token authentication (optional, used for exec auth)" - type = string - default = null -} - # Tagging variable "additional_tags" { description = "Additional tags to apply to all resources" @@ -446,12 +440,6 @@ variable "rds_vpc_id" { default = null } -variable "rds_subnet_ids" { - description = "Subnet IDs for the RDS database" - type = list(string) - default = [] -} - variable "rds_create_monitoring_role" { description = "Whether to create the RDS monitoring role" type = bool From 61e4df4211c9b72a4da0d7f672c9c67eee839979 Mon Sep 17 00:00:00 2001 From: 43z708 Date: Fri, 19 Sep 2025 17:19:42 +0900 Subject: [PATCH 2/3] Formatted --- examples/mpc-party/main.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/mpc-party/main.tf b/examples/mpc-party/main.tf index 71c1258..b6615e6 100644 --- a/examples/mpc-party/main.tf +++ b/examples/mpc-party/main.tf @@ -65,7 +65,7 @@ module "mpc_party" { kms_image_attestation_sha = var.kms_image_attestation_sha kms_deletion_window_in_days = var.kms_deletion_window_in_days - nodegroup_source_security_group_ids = var.nodegroup_source_security_group_ids + nodegroup_source_security_group_ids = var.nodegroup_source_security_group_ids nodegroup_additional_security_group_ids = var.nodegroup_additional_security_group_ids nodegroup_enable_ssm_managed_instance = var.nodegroup_enable_ssm_managed_instance nodegroup_use_latest_ami_release_version = var.nodegroup_use_latest_ami_release_version From 01b2424bb5a1299e63348f65e979440a2feb0792 Mon Sep 17 00:00:00 2001 From: 43z708 Date: Wed, 24 Sep 2025 15:40:18 +0900 Subject: [PATCH 3/3] Remove nodegroup_source_security_group_ids and rds_prefix --- examples/mpc-party/main.tf | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/mpc-party/main.tf b/examples/mpc-party/main.tf index 9d95a00..6a155d7 100644 --- a/examples/mpc-party/main.tf +++ b/examples/mpc-party/main.tf @@ -65,7 +65,6 @@ module "mpc_party" { kms_image_attestation_sha = var.kms_image_attestation_sha kms_deletion_window_in_days = var.kms_deletion_window_in_days - nodegroup_source_security_group_ids = var.nodegroup_source_security_group_ids nodegroup_additional_security_group_ids = var.nodegroup_additional_security_group_ids nodegroup_enable_ssm_managed_instance = var.nodegroup_enable_ssm_managed_instance nodegroup_use_latest_ami_release_version = var.nodegroup_use_latest_ami_release_version @@ -80,7 +79,6 @@ module "mpc_party" { # RDS Configuration enable_rds = var.enable_rds rds_db_name = var.rds_db_name - rds_prefix = var.rds_prefix rds_create_monitoring_role = var.rds_create_monitoring_role rds_manage_master_user_password = var.rds_manage_master_user_password rds_username = var.rds_username