Keymap stopped working

[henrikbjorn]

Doing my bi weekly :Lazy update of plugins the accept_line and accept_word key maps stopped working.

Reverting back to the previous installed commit f7732213e41995439171f35bdd2bf1c809f8e8e7 and it is working again.

my config

return {
  {
    'zbirenbaum/copilot.lua',
    cmd = 'Copilot',
    event = 'InsertEnter',
    opts = {
      suggestion = {
        enabled = true,
        auto_trigger = true,
        keymap = {
          accept = "<M-l>",
          accept_word = "<M-k>",
          dismiss = "<C-]>",
        }
      }
    }
  }
}

[AntoineGS]

ouff a lot happened between now and that commit, have you tried any other commits in between?

Also, can you change your config to include the following and report back the logs?

logger = {
    file_log_level = vim.log.levels.TRACE,
}

If you are unsure where the log file is it is displayed when running :checkhealth.
Thank you,

[henrikbjorn]

@AntoineGS I just tried every commit by changing the commit hash, restarting and use lazy to install, restart and open a file.

I works when i do nvim somefile but it does not work when I open files through telescope

[henrikbjorn]

Just to be clear. I will still show the suggestion, the keymap just dosen't work.

[henrikbjorn]

@AntoineGS I tried all of the commits again, one by one and opening a file through telescope to check if it worked or not.

This is the commit 56ae9be that breaks for me.

cb1a982 this one works.

[AntoineGS]

This is good information thank you.
Are you able to provide a log with commit 56ae9be?
While I don't use telescope I do use snacks.picker, and I am not seeing the problem :(

[mikew]

Also doesn't seem consistent. I have two files opened, both via Telescope, in one my mapping works, in the other it doesn't.

[Woit]

Have same issue. Looks like if open file through Telescope the keymaps is simply not register for current buffer. Also issue here if open file with neo-tree

[AntoineGS]

Ok time to install Telescope lol

Edit: It works on my machine with Telescope too, I will need a log file to figure out the chain of events 😭

[AntoineGS]

I doubt this will fix it but I pushed a few minor tweaks including which autocmd is used to check if the buffer should be attached.

[henrikbjorn]

@AntoineGS the log file :) https://gist.github.com/henrikbjorn/c25dd846c92ff3b667f03282c07fc3d6

[JulienZD]

@AntoineGS following up on my comment from #573.

I did some more testing (on the latest commit, abc8bda) and it definitely seems to be related to a Telescope picker, as others have mentioned (my assumption is that the keymaps break if opening a telescope picker is the first thing you do after starting nvim)

If I open nvim, then go to a file using telescope, then the keymap to accept doesn't work (suggestions still show).

The keymaps do work if I open nvim, then first manually navigate to a file using oil.nvim (I assume that any other way works too). The interesting part is that they keep working even after navigating to another file with telescope.

Below are two log files, one where I first open telescope (with the broken keymaps), and one where I first go to a file and then telescope (with working keymaps). I added some of my own logs to see if I could figure out more, but they're not really adding much, feel free to ignore those.

copilot-lua-telescope-first.log

copilot-lua-oil-first.log

[henrikbjorn]

Seems to work with snacks.picker so just switched from Telescope to that. Folke ftw :)

[JulienZD]

If I add the following to my copilot.lua config it seems to fix keymaps with telescope. Note that this might break workflows for some people (all files I work with have filetypes, so it doesn't matter for me):

filetypes = {
  [''] = false,
},

Iterating a bit more on my previous comment, it seems like the telescope pickers resolve to an empty filetype in util.should_attach, so if I just instruct copilot.lua to ignore empty filetypes then the keymaps behave as they should, as they're never registered on the telescope pickers (assuming that this is what's breaking it).