net: utils: Fix unused function warning

thughes · nashif · commit 67e07b7a4116 · 2025-02-08T19:45:38.000-05:00
Building with clang warns:

subsys/net/ip/utils.c:600:24: error: unused function 'pkt_calc_chksum'
[-Werror,-Wunused-function]
static inline uint16_t pkt_calc_chksum(struct net_pkt *pkt, uint16_t sum)
                       ^

pkt_calc_chksum is called by net_calc_chksum, which only exists when
CONFIG_NET_NATIVE_IP is defined.

Signed-off-by: Tom Hughes &lt;tomhughes@chromium.org&gt;
diff --git a/subsys/net/ip/utils.c b/subsys/net/ip/utils.c
@@ -636,6 +636,7 @@ uint16_t calc_chksum(uint16_t sum_in, const uint8_t *data, size_t len)
 	}
 }
 
+#if defined(CONFIG_NET_NATIVE_IP)
 static inline uint16_t pkt_calc_chksum(struct net_pkt *pkt, uint16_t sum)
 {
 	struct net_pkt_cursor *cur = &pkt->cursor;
@@ -673,7 +674,6 @@ static inline uint16_t pkt_calc_chksum(struct net_pkt *pkt, uint16_t sum)
 	return sum;
 }
 
-#if defined(CONFIG_NET_NATIVE_IP)
 uint16_t net_calc_chksum(struct net_pkt *pkt, uint8_t proto)
 {
 	size_t len = 0U;

Original file line number	Diff line number	Diff line change
`@@ -636,6 +636,7 @@ uint16_t calc_chksum(uint16_t sum_in, const uint8_t *data, size_t len)`
`636`	`636`	`}`
`637`	`637`	`}`
`638`	`638`
	`639`	`+#if defined(CONFIG_NET_NATIVE_IP)`
`639`	`640`	`static inline uint16_t pkt_calc_chksum(struct net_pkt *pkt, uint16_t sum)`
`640`	`641`	`{`
`641`	`642`	`struct net_pkt_cursor *cur = &pkt->cursor;`
`@@ -673,7 +674,6 @@ static inline uint16_t pkt_calc_chksum(struct net_pkt *pkt, uint16_t sum)`
`673`	`674`	`return sum;`
`674`	`675`	`}`
`675`	`676`
`676`		`-#if defined(CONFIG_NET_NATIVE_IP)`
`677`	`677`	`uint16_t net_calc_chksum(struct net_pkt *pkt, uint8_t proto)`
`678`	`678`	`{`
`679`	`679`	`size_t len = 0U;`