Commit d5d2f22
committed
Revert "test harness: Rewrite the columnar pretty-printer without external tools." and "travis: Remove bsdmainutils since column(1) has been removed, three commits ago."
This reverts commits ea7c165 and
3d81c83.
When "have 6 expectations and 4 region_highlight entries", the pure-zsh
implementation printed them as follows:
not ok 7 - cardinality check - have 6 expectations and 4 region_highlight entries: «expected_region_highlight=( $'1 1 builtin' $'3 6 comment' $'8 13 comment' $'15 15 default' $'16 21 comment' $'22 22 default' )»
«region_highlight=( $'0 1 builtin' $'2 6 comment' $'7 13 comment' $'14 22 default' )»
# expected_region_highlight '22 22 default'
# '1 1 builtin' region_highlight
# '3 6 comment' '0 1 builtin'
# '8 13 comment' '2 6 comment'
# '15 15 default' '7 13 comment'
# '16 21 comment' '14 22 default'
Whereas the column(1)-based implementation prints them as follows:
not ok 7 - cardinality check - have 6 expectations and 4 region_highlight entries: «expected_region_highlight=( $'1 1 builtin' $'3 6 comment' $'8 13 comment' $'15 15 default' $'16 21 comment' $'22 22 default' )» «region_highlight=( $'0 1 builtin' $'2 6 comment' $'7 13 comment' $'14 22 default' )»
# expected_region_highlight region_highlight
# '1 1 builtin' '0 1 builtin'
# '3 6 comment' '2 6 comment'
# '8 13 comment' '7 13 comment'
# '15 15 default' '14 22 default'
# '16 21 comment'
# '22 22 default'
Ultimately, this difference is down to the pure-zsh implementation
getting the arguments as a single list, whereas paste(1) gets two
separate lists.1 parent 8eaa414 commit d5d2f22
2 files changed
+5
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
233 | | - | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
234 | 237 | | |
235 | 238 | | |
236 | 239 | | |
| |||
0 commit comments