-
Notifications
You must be signed in to change notification settings - Fork 80
Open
Description
Describe the bug
In the following line, the file opened in the list comprehension is not explicitly closed. In Python, it's generally good practice to open files using the with
statement, which ensures that the file is properly closed after its suite finishes, even if an exception is raised. Not closing files can lead to memory leaks or issues with file locks, especially in larger applications or if the code is run multiple times in a loop.
filelist = [line.rstrip('\n') for line in open(name)]
Expected behavior
The file is closed automatically. A better approach would be:
with open(name) as file:
filelist = [line.rstrip('\n') for line in file]
Metadata
Metadata
Assignees
Labels
No labels