Add P2IDE note example #704
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partylikeits1983
added
the
examples
partylikeits1983
commented
Oct 9, 2025
partylikeits1983
commented
Oct 9, 2025
greenhat
reviewed
Oct 10, 2025
greenhat
requested changes
Oct 28, 2025
| let reclaim_height = inputs[3]; | ||
|
|
||
| // make sure the number of inputs is 4 | ||
| assert_eq(inputs.len().into(), Felt::from(4u32)); |
There was a problem hiding this comment.
The code before this assert_eq indexes inputs[0..=3] before checking how many items were provided, so a malformed note input will panic before this assert. Consider moving it to the start of the function.
| let reclaim_height = Felt::new(0); | ||
|
|
||
| // Create the p2ide note with only 2 inputs (account ID) | ||
| // This is a simplified P2IDE note without timelock/reclaim functionality |
There was a problem hiding this comment.
It seems like it's a full-fledged P2IDE note with a reclaim feature.
greenhat
reviewed
Oct 28, 2025
| let reclaim_height = inputs[3]; | ||
|
|
||
| // make sure the number of inputs is 4 | ||
| assert_eq(inputs.len().into(), Felt::from(4u32)); |
There was a problem hiding this comment.
There is a felt! macro in the SDK. So Felt::from(4u32) can be substituted with felt!(4).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the P2IDE note as an example note.