Skip to content

Conversation

einar-polygon
Copy link
Contributor

This continues the work in #427 and addresses one problem: CREATE and CREATE2 required memory dumps to obtain the relevant contract code and code_hash for call stack simulation, and we opted instead to fail over to simulation, since memory dumps were slow.

This branch introduces the following changes:

  • Reinstantiate the match case for CREATE and CREATE2, but ignore code and code_hash.
  • Prove only the current context. The old version generates all Jumpdest proofs in the very first context. This meant that the witness had to provide the relevant mapping between code_hash and context. This change means two things: current_code and current_code_hash is always available, so we do away with the mapping in the witness, essentially simplifying it to a mapping ctx->[offset].
  • Simplify the witness including removal of the tracking of code and code_hash in the Jumpdest generation.

Status: The first 100 blocks on testchain2 succeed, but there are still many errors later.

@einar-polygon einar-polygon added crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: zero_bin Anything related to the zero-bin subcrates. labels Nov 3, 2024
@einar-polygon einar-polygon self-assigned this Nov 3, 2024
@github-actions github-actions bot added crate: trace_decoder Anything related to the trace_decoder crate. ci labels Nov 3, 2024
@Nashtare
Copy link
Collaborator

Nashtare commented Nov 4, 2024

QQ: shouldn't this be targeting the JD branch instead of develop?

@github-actions github-actions bot removed the ci label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: trace_decoder Anything related to the trace_decoder crate. crate: zero_bin Anything related to the zero-bin subcrates.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

6 participants