Unifying type 2 and type 1. #768
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto develop_w_type_2
Closed
Nashtare
force-pushed
the
type2_merge_linda
branch
from
de15694 to
7f89495
Compare
|
Related ticket: #781 |
github-actions
bot
added
the
crate: mpt_trie
Nashtare
force-pushed
the
type2_merge_linda
branch
from
f864db2 to
f0bb4f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am opening this draft PR so that everyone can look at the current state of the unification of type 1 and type 2 looks like. This way, we can spot mistakes/improvements "earlier" on and make the necessary changes quickly! (Note that some tests are still failing in the current state, and some parts could surely be simplified / cleaned up.)
In this PR, the Kernel has been adapted to support both type 1 and type 2, and the
Worldtrait has been moved toevm_arithmetization. Some other structures -- such asEitherRlp(for eitherMptAccountRlporSmtAccountRlp-- have also been introduce to reduce the usage of feature gating.