Huge refactoring #35
Open
Huge refactoring #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Lucas, I figured out how easy it was to publish a new project on npm, so I did it already under the name tidalpromise... any suggestions in the code are welcome. Thank you in advance. Lucas Deters |
|
Hi Lucas, amazing work! I'll check better on the next days! I'll contact you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Lucas,
I did a major refactoring in your project... it's almost a new project, because all methods where promisified... I also added support to playlist manipulation (create, delete, add and remove tracks). One last thing I did was to implement a quota mecanism... I don't expect you to pull the changes because they will break your current projects, but I would like to know if you would like to adopt the code as a new project, or if you can help me to do it...
I changed the search examples and create a new example for playlist manipulation, so you can see how it works... any suggestions are welcome... I'm a beginner in JS development.
Thank you!
Lucas Deters