-
Notifications
You must be signed in to change notification settings - Fork 18
WIP: EquivariantTensors Backend #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
See #312 which targets this PR and implements most of the remaining steps (but still needs to be cleaned up) |
|
UPDATE: I think I now have all functionality that we can expect ET to provide. My plan is to finalize the unit tests and then I think we can make a plan how to proceed. Here is a tentative list: Backend
Low model level
User-facing
Speculative
|
New One Body Potential
ET Pair Potential Model
|
@jameskermode -- this now has one-body and pair potentials and is in principle at a place where one could put together a complete ACE model, basis and calculators and start testing backward compatibility. The only technical thing left to do for me is testing the splines. (the functionality is in principle already there...) |
|
Great, I'll rebase my calculators PR on this and continue |
|
I realized I made a mistake in the design of the basis interface. I'm returning the site energy basis but for each center-atom species, the basis occupies the same indices. We need to perform a transformation so that bases for different species occupy separate indices. A question is whether this should be done at the site potential model level or at the calculator level. Maybe it can be done at the level of the site potential wrapper calculator? But it may need some additional logic. we should discuss what a good general-purpose approach is before charging ahead I think. |
dev-0.10 uses ET only superficially, this PR is to integrate ET more deeply, remove duplicated functionality, with the end-goal to enable GPU evaluation.
forcessite energy gradientsbasissite energy basis and site energy gradient basisTo decide before merging?