Splines #317
Merged
Splines #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add splinification functionality for the radial and pair basis.
It turns out the P4ML splines are just not flexible enough, but it should be straightforward to implement something suitable for ACEpotentials. Only question is whether this should live in ACEpotentials or in ET. Will sleep on it and continue tomorrow...
main splines code is now in ET, some basic functionality to construct spline radial and pair bases is now provided, should be basis and jacobian and GPU compatible if used correctly, but likely missing a few use-cases.
Overall this provides the intended functionality which we can bug-fix or expand as required as we run into problems.