feat: Added an update to CoreDNS #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… create-pathways is used, it will default to CoreDNS.
…cessary' function.
…tions, along with some helper functions.
DannyLiCom
requested review from
44past4,
sharabiani,
pawloch00,
BluValor,
gcie and
RoshaniN
as code owners
|
This PR is from #501 due to fork issue |
pawloch00
reviewed
Jul 18, 2025
pawloch00
reviewed
Jul 18, 2025
|
@pawloch00 Please review it again. |
pawloch00
approved these changes
Jul 24, 2025
|
@sharabiani ptal |
|
@wstcliyu @pawloch00 It also seems to be caused by an IP connection refused error. |
|
The test that failed wasn't any of paths mentioned in PR description |
|
Right, the problem only appeared after I update the branch. |
|
Please add github workflow test that will clearly test this path and check for presence of coreDNS deployment. Also, if possible add checks to existing tests, that existing DNS deployment was not changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Enhance DNS Scalability for Large-Scale Testing:
Testing / Documentation
When using the command
python3 xpk.py cluster create-pathways and python3 xpk.py cluster createto create a cluster, CoreDNS will be used by default.