Add tpu resouce flavor to kueue #532
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wstcliyu
requested review from
Obliviour,
44past4,
sharabiani,
pawloch00,
BluValor,
gcie and
RoshaniN
as code owners
|
This looks good to me, but I wanted to check one thing, would you be able to confirm that a CPU pod doesn't land on a TPU nodepool? May need to add tolerations for this in XPK, but not sure. You can test this by creating a simple cluster (or using an existing cluster) that does not have any CPU nodepools, and launch a cpu only jobset on it and confirm that it's unschedulable. |
wstcliyu
force-pushed
the
wstcliyu/kueue-tpu-flavor
branch
4 times, most recently
from
937615d to
1bb60af
Compare
SujeethJinesh
approved these changes
Jul 18, 2025
src/xpk/core/pathways.py
Outdated
| nominalQuota: 2000G""" | ||
| if args.enable_pathways: | ||
| return resources_yaml | ||
| # resources_yaml = """- coveredResources: ["cpu", "memory"] |
There was a problem hiding this comment.
I'd inline this function into the above.
wstcliyu
force-pushed
the
wstcliyu/kueue-tpu-flavor
branch
from
95d7ddb to
832f82e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Testing / Documentation
Testing details.