Skip to content

[Slice] Refactor isRelevantWorkload(). #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

[Slice] Refactor isRelevantWorkload(). #568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions slice/internal/controller/workload_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ func (r *WorkloadReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
return ctrl.Result{}, nil
}

if !r.isRelevantWorkload(wl, log) {
if err = validateRelevantWorkload(wl); err != nil {
log.V(3).Info(fmt.Sprintf("Skipping workload as it %s", err.Error()))
return ctrl.Result{}, nil
}

Expand Down Expand Up @@ -164,28 +165,23 @@ func (r *WorkloadReconciler) shouldFinalize(wl *kueue.Workload) bool {
return !wl.DeletionTimestamp.IsZero() || workload.IsFinished(wl) || workload.IsEvicted(wl) || !workload.IsActive(wl)
}

func (r *WorkloadReconciler) isRelevantWorkload(wl *kueue.Workload, log logr.Logger) bool {
func validateRelevantWorkload(wl *kueue.Workload) error {
if !hasRelevantPodSet(wl.Spec.PodSets) {
log.V(3).Info("Skipping workload as it does not have a relevant podset")
return false
return errors.New("does not have a relevant podset")
}
if !workload.HasQuotaReservation(wl) {
log.V(3).Info("Skipping workload as it does not have a quota reservation")
return false
return errors.New("does not have a quota reservation")
}
if wl.Status.Admission == nil {
log.V(3).Info("Skipping workload as it has no admission")
return false
return errors.New("has no admission")
}
if !topology.AnyAssignment(wl.Status.Admission) {
log.V(3).Info("Skipping workload as it has no topology assignment")
return false
return errors.New("has no topology assignment")
}
if !topology.AllAssignmentsValid(wl.Status.Admission) {
log.V(3).Info("Skipping workload as it has invalid topology assignments")
return false
return errors.New("has invalid topology assignments")
}
return true
return nil
}

func hasRelevantPodSet(podSets []kueue.PodSet) bool {
Expand Down Expand Up @@ -219,7 +215,7 @@ func parseTopologyAssignmentIntoNodeSelector(slice *v1alpha1.Slice, wl *kueue.Wo
nodeSelectors := sets.New[string]()
for _, psa := range wl.Status.Admission.PodSetAssignments {
// we already validated that all assignments have a valid level,
// in isRelevantWorkload.
// in validateRelevantWorkload.
subblockLevelIndex := topology.SubblockLevelIndex(&psa)
for _, domain := range psa.TopologyAssignment.Domains {
nodeSelectors.Insert(domain.Values[subblockLevelIndex])
Expand Down
Loading