Potential fix for code scanning alert no. 25: Disabled TLS certificate check #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e check Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
akabarki76
temporarily deployed
to
cli-automation
GitHub Actions
Inactive
akabarki76
had a problem deploying
to
cli-automation
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/AKA-NETWORK/cli/security/code-scanning/25
To address the issue, the
InsecureSkipVerify: truesetting should be replaced with custom certificate validation logic. This can be achieved by implementing a customVerifyPeerCertificatefunction. This function should verify the self-signed certificates based on specific criteria, such as expected certificate fingerprint or other attributes relevant to the context.The changes will involve:
VerifyPeerCertificatefunction within thetls.Configconfiguration.InsecureSkipVerifyfield from the configuration.Suggested fixes powered by Copilot Autofix. Review carefully before merging.