Add file image preview for Graph Editor #2710
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is another port from my editor. For now there is no way to support colorspace transforms via C++ thus images do not consider input space. Let me know what you think. Thanks. |
kwokcb
commented
Dec 3, 2025
| { | ||
| count++; | ||
|
|
||
| // Add space for image previews |
Contributor
Author
There was a problem hiding this comment.
Since we are using a fixed height, we need to take into consideration space for image previews.
| { | ||
| unsigned int textureId = 0; | ||
| int width = 0, height = 0; | ||
| mx::ImagePtr image = imageHandler->acquireImage(filePath); |
Contributor
Author
There was a problem hiding this comment.
This will reusage images from the handler's cache if found.
| float aspect = (height > 0) ? (float)width / (float)height : 1.0f; | ||
| ImVec2 imagePreviewSize(previewSize, previewSize / aspect); | ||
|
|
||
| ImGui::Image((void*)(intptr_t)textureId, imagePreviewSize); |
Contributor
Author
There was a problem hiding this comment.
This is just preview scaling not actual image pixels resizing.
| _autoLayout(false), | ||
| _frameCount(INT_MIN), | ||
| _fontScale(1.0f), | ||
| _previewSize(previewWidth), |
Contributor
Author
There was a problem hiding this comment.
A size of 0 will turn on previews.
Member
|
This looks like a great contribution, thanks @kwokcb, and I'm CC'ing @lfl-eholthouser for a more formal review! |
jstone-lucasfilm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Update
For better user feedback on what images are being used from the UI, this change adds image previews for file image nodes
Details:
filenameinput image preview256px but is settable from the command line using the--previewWidthargument. A size of <= 0 will turn off previews.Implementation notes
Caveats
Examples