Fix slightly broken overload resolution #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I committed #746, in which I made double declarations of user functions to be a warning, I changed some declarations to remove duplicates in stdosl.h, not realizing that there was some overloading resolution logic that was order dependent (as was so astutely pointed out and attempted to be solved by Marsupial in #837) and that I was inadvertently depending on the redundant declaration to get it right.
Ugh, so I broke it, then Marsupial's patch fixed it. Then Marsupial discovered some problems (not this!) with his patch and we reverted it, thus re-introducing the bug.
I'm reviewing another attempt to fix the order dependency problem once and for all (#844), but in the mean time, this fix to stdosl.h fixes the pow and fmod cases that are broken at the moment.