Fix rez-pkg-cache to preserve symlinks instead of following them #2057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pmady
force-pushed
the
fix-pkg-cache-symlinks
branch
2 times, most recently
from
14e9550 to
1f16940
Compare
By default, shutil.copytree follows symlinks which can cause failures when symlink targets are inaccessible. This change adds symlinks=True parameter to preserve symlinks instead of following them, matching the default behavior of rez-cp. Fixes AcademySoftwareFoundation#2047 Signed-off-by: pmady <pavan4devops@gmail.com>
pmady
force-pushed
the
fix-pkg-cache-symlinks
branch
from
1f16940 to
cc26064
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #2047 where
rez-pkg-cachefollows symlinks during package caching, which can cause failures when symlink targets are inaccessible.Problem
The
PackageCache.add_variant()method usesshutil.copytree()without thesymlinksparameter, which defaults to following symlinks. This causes failures when:Solution
Added
symlinks=Trueparameter toshutil.copytree()call inpackage_cache.pyline 408. This preserves symlinks instead of following them, matching the default behavior ofrez-cp.Changes
src/rez/package_cache.py: Addedsymlinks=Truetoshutil.copytree()callCHANGELOG.md: Added entry for this fixTesting
The fix aligns with how
rez-cphandles symlinks (which has a--follow-symlinksflag that defaults to False). Thereplacing_copy()function infilesystem.pyalready uses this pattern correctly.Fixes #2047