PORTS - Kim&Cloudy #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ur user interface
… been tested and run properly
slack.rbWhat We're Looking For
|
CheezItMan
reviewed
Mar 31, 2019
| end | ||
|
|
||
| def details | ||
| super.push("topic", "member_count") |
| end | ||
|
|
||
| def self.get(url, params) | ||
| user_data = HTTParty.get(url, query: params) |
There was a problem hiding this comment.
It's not always user data, so this variable name could use some improvement.
| end | ||
|
|
||
| def self.list | ||
| raise NotImplementedError, "Implement me in a child class!" |
| end | ||
|
|
||
| def select_user(user_descriptor) | ||
| users.find do |user| |
There was a problem hiding this comment.
When using find it's intended to be used like this:
@selected = users.find do |user|
user_descriptor == user.name || user_descriptor == user.slack_id
end| end | ||
| end | ||
|
|
||
| if @selected == nil |
There was a problem hiding this comment.
There's a subtle error in the way you have it written. Consider:
- I select a valid user
- Then I try to select an invalid user name
- Since
@selectedis notnilwe won't get the returned error message.
| end | ||
| end | ||
|
|
||
| def select_channel(channel_descriptor) |
There was a problem hiding this comment.
See notes for select_user
Also if you notice the methods are identical... you could have one method that does both!
| end | ||
|
|
||
| describe "#send_message" do | ||
| it "raises an Error if incorrect parameters are given" do |
| @@ -0,0 +1,156 @@ | |||
| require_relative "test_helper" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slack.rb
Congratulations! You're submitting your assignment!
You and your partner should collaborate on the answers to these questions.
Comprehension Questions