Skip to content

Daniela Sanchez - Leaves #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dnsanche wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Daniela Sanchez - Leaves #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
461eb89
Only tests for nil arrays aren't passing
dnsanche Aug 22, 2019
26e74a8
All tests passed
dnsanche Sep 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions lib/array_equals.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,29 @@
# Determines if the two input arrays have the same count of elements
# and the same integer values in the same exact order
def array_equals(array1, array2)
true_false_array = []
Copy link

@CheezItMan CheezItMan Sep 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a little wasteful to build an entire array here. Not so efficient. It does work however.


if array1 == nil || array2 == nil
if array1 == nil && array2 == nil
true_false_array << "true"
else
true_false_array << "false"
end
else
if array1.length == array2.length
array1.length.times do |index|
if array1[index] == array2[index]
true_false_array << "true"
else
true_false_array << "false"
end
end
else
true_false_array << "false"
end
end

return true_false_array.delete("false") == nil
raise NotImplementedError
end