Skip to content

Branches - Linnea #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
llinneaa wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Branches - Linnea #44

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cc495b
works but has puts statements
llinneaa Sep 3, 2019
fd0fe3c
cleaned up code, changed boolean logic
llinneaa Sep 3, 2019
c47b623
deleted arrays from code
llinneaa Sep 3, 2019
187483b
made code compatible with tests
llinneaa Sep 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion lib/array_equals.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,23 @@
# Determines if the two input arrays have the same count of elements
# and the same integer values in the same exact order

def array_equals(array1, array2)
raise NotImplementedError
if array1 == nil && array2 == nil
Copy link

@CheezItMan CheezItMan Sep 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also implement this with

if array1.nil?  && array2.nil?
  return true
elsif array1.nil? || array2.nil? # one or the other is nil, but not both

return true
elsif array1 == nil && array2 != nil
return false
elsif array1 != nil && array2 == nil
return false
end

if array1.length != array2.length
return false
end
array1.each_with_index do |char, i|
if array1[i] != array2[i]
return false
end
end
return true
end