Branches - Erika #47
Open
Branches - Erika #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 5, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
You should run the tests here, this isn't working in many cases. Take a look at my comments and let me know any questions you have.
| # and the same integer values in the same exact order | ||
| def array_equals(array1, array2) | ||
| raise NotImplementedError | ||
|
|
There was a problem hiding this comment.
You should check to see if the arrays are both nil first. You can't for example do .each on a `nil.
lib/array_equals.rb
Outdated
| if array1[index] != array2[index] | ||
| match = false | ||
| end | ||
| return match |
There was a problem hiding this comment.
This will cause the loop to exit after 1 iteration. So if the 1st elements are the same it will return true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.