Leaves - Mariya #28
Open
Leaves - Mariya #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Apr 1, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Well you got the newman_conway method, but it looks like you weren't able to finish the subsequence problem. I pointed out a few things there, let me know if you have further questions.
| max = nums[0] | ||
| current = nums[0] | ||
|
|
||
| nums.each do |index| |
There was a problem hiding this comment.
index here won't be an index into the array, it will be a value.
Maybe you meant:
Suggested change
| nums.each do |index| | |
| nums.length.time do |index| |
|
|
||
| raise NotImplementedError, "Method not implemented yet!" | ||
| max = nums[0] | ||
| current = nums[0] |
There was a problem hiding this comment.
Otherwise you will add nums[0] twice.
Suggested change
| current = nums[0] | |
| current = 0 |
Comment on lines
+2
to
4
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def max_sub_array(nums) |
There was a problem hiding this comment.
I think you're on the right track, but not quite there yet. 😢
Comment on lines
+3
to
+6
| # Time complexity: O(1) | ||
| # Space Complexity: O(n) | ||
|
|
||
| def newman_helper(num, newman_hash) |
There was a problem hiding this comment.
This works, although you could use an array just as easily as a hash here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.