Branches - Julia Bouvier #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Nov 20, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Overall nice work, you hit the learning goals here. Well done.
| # Hint, you may want a recursive helper method | ||
| # Time Complexity - O(n) | ||
| # Space Complexity - O(n) | ||
| def fibonacci(n) |
There was a problem hiding this comment.
This works, but the solution keeps an array of all the fibonacci numbers from 0 to n for the entire length of the recursive calls. Instead you only need to keep the last 2 fibonacci numbers.
| # Space Complexity - ? | ||
| # Time Complexity - O(n) | ||
| # Space Complexity - O(n) | ||
| def super_digit(n) |
There was a problem hiding this comment.
👍
Your time complexity is right, if n is the number of digits.
| # Space Complexity - ? | ||
| # Time Complexity - Is this O(2^n) (exponential), because the method gets called twice each time? | ||
| # Space Complexity - Is this O(2^n) (exponential), because the method gets called twice each time? | ||
| def refined_super_digit(n, k) |
Comment on lines
+18
to
+19
| # Time Complexity - Is this O(2^n) (exponential), because the method gets called twice each time? | ||
| # Space Complexity - Is this O(2^n) (exponential), because the method gets called twice each time? |
There was a problem hiding this comment.
This isn't exponential since the number of digits goes down by 1 with each iteration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.