Daniela - Leaves #27
Open
Daniela - Leaves #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Nov 20, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Overall nice work, take a look at my comments and let me know if you have any questions.
| # Time Complexity - O(n) | ||
| # Space Complexity - ? (should be O(n)) | ||
| # Hint, you may want a recursive helper method | ||
| def fibonacci(n) |
There was a problem hiding this comment.
This works, but you don't need to keep the entire list of fibonacci numbers for the entire length of the recursion. Instead you only need to keep the last two fibonacci numbers.
| def super_digit(n) | ||
|
|
||
|
|
||
| return n if [0,1,2,3,4,5,6,7,8,9].include?(n) == true |
There was a problem hiding this comment.
Why not just:
Suggested change
| return n if [0,1,2,3,4,5,6,7,8,9].include?(n) == true | |
| return n if n < 10 |
| # Space Complexity - ? | ||
| # Time Complexity - O(n), depends on number of digits | ||
| # Space Complexity : O(1) as the array of digits will always be same and I will always have same variables (sum, reminder, superdigit) | ||
| def refined_super_digit(n, k) |
There was a problem hiding this comment.
This works, but you can use the super_digit method previously to help solve the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.