forked from AdaGold/Hashmap
-
Notifications
You must be signed in to change notification settings - Fork 47
Time - Vera #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
veralizeth
wants to merge
5
commits into
Ada-C13:master
Choose a base branch
from
veralizeth:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Time - Vera #26
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8c7a5cd
Array_intersection hash table
veralizeth 2441b41
Permutations solved
veralizeth bad3eac
Refectoring code
veralizeth e9f8282
Test added if the count letters are different
veralizeth 8c7913a
Palindrome_permutation implementation
veralizeth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,19 @@ | ||
|
|
||
| def intersection(list1, list2) | ||
| raise NotImplementedError, "Intersection not implemented" | ||
| # raise NotImplementedError, "Intersection not implemented" | ||
| intersec_result = [] | ||
|
|
||
| hash = {} | ||
|
|
||
| list1.each do |number| | ||
| hash[number] = true | ||
| end | ||
|
|
||
| list2.each do |number| | ||
| if !hash[number].nil? | ||
| intersec_result << number | ||
| end | ||
| end | ||
|
|
||
| return intersec_result | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,30 @@ | ||
|
|
||
| def count_chars_in_string (string) | ||
| hash = {} | ||
|
|
||
| string.each_char do |char| | ||
| if hash.key?(char) | ||
| hash[char] += 1 | ||
| else | ||
| hash[char] = 1 | ||
| end | ||
| end | ||
| return hash | ||
| end | ||
|
|
||
| # the number of characters with odd number of occurences. | ||
| # If this countcount happens to exceed 1 at any step, | ||
| # we conclude that a palindromic permutation isn't possible for the string. | ||
|
|
||
| def palindrome_permutation?(string) | ||
|
Comment on lines
+15
to
19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| raise NotImplementedError, "palindrome_permutation? not implemented" | ||
| end | ||
| # raise NotImplementedError, "palindrome_permutation? not implemented" | ||
|
|
||
| odd_ocurrences_count = 0 | ||
| num_ocurrences_hash = count_chars_in_string(string) | ||
|
|
||
| num_ocurrences_hash.each do |key, value| | ||
| odd_ocurrences_count += value % 2 | ||
| end | ||
|
|
||
| return odd_ocurrences_count < 2 | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,27 @@ | ||
|
|
||
|
|
||
| def count_chars_in_string (string) | ||
| hash = {} | ||
|
|
||
| string.each_char do |char| | ||
| if hash.key?(char) | ||
| hash[char] += 1 | ||
| else | ||
| hash[char] = 1 | ||
| end | ||
| end | ||
|
|
||
| return hash | ||
| end | ||
|
|
||
| def permutations?(string1, string2) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 Well done |
||
| raise NotImplementedError, "permutations? not implemented" | ||
| end | ||
| # raise NotImplementedError, "permutations? not implemented" | ||
| return false if string1.length != string2.length | ||
| # Return a boolean value. | ||
|
|
||
| hash_string1_counting = count_chars_in_string(string1) | ||
| hash_string2_counting = count_chars_in_string(string2) | ||
|
|
||
| return hash_string1_counting == hash_string2_counting | ||
|
|
||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍