Space - Diana #32
Open
Space - Diana #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Apr 2, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Good work, you hit most of all the learning goals here. Well done.
Take a look at my comments and let me know if you have any questions.
Comment on lines
+9
to
+13
| intersection_array = list2.map do |num| | ||
| num if lookup_hash[num] | ||
| end | ||
|
|
||
| return intersection_array.compact |
There was a problem hiding this comment.
Use map if you want to do an operation on each element in the array. In this case you want to get only some of the elements of the array.
Suggested change
| intersection_array = list2.map do |num| | |
| num if lookup_hash[num] | |
| end | |
| return intersection_array.compact | |
| intersection_array = list2.select do |num| | |
| lookup_hash[num] | |
| end | |
| return intersection_array |
| @@ -1,3 +1,25 @@ | |||
| def intersection(list1, list2) | |||
Comment on lines
+19
to
+23
| if number_of_odd > 1 | ||
| return false | ||
| else | ||
| return true | ||
| end |
There was a problem hiding this comment.
Suggested change
| if number_of_odd > 1 | |
| return false | |
| else | |
| return true | |
| end | |
| return number_of_odd > 1 |
| @@ -1,4 +1,21 @@ | |||
|
|
|||
| def permutations?(string1, string2) | |||
There was a problem hiding this comment.
This would fail for something like heelo and hello. Instead of making lookup_hash[letter] = true instead count the number of times each letter appears.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.