Time - Vicki #21
Open
Time - Vicki #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 1, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Well done, take a look at my comments and let me know what questions you have.
Comment on lines
+24
to
26
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(value) |
Comment on lines
+27
to
+33
| if @head.nil? | ||
| @head = @tail = Node.new(value) | ||
| else | ||
| new_node = Node.new(value,@head) | ||
| @head.previous = new_node | ||
| @head = new_node | ||
| end |
There was a problem hiding this comment.
This can be simplified a bit
Suggested change
| if @head.nil? | |
| @head = @tail = Node.new(value) | |
| else | |
| new_node = Node.new(value,@head) | |
| @head.previous = new_node | |
| @head = new_node | |
| end | |
| @head = Node.new(value, @head) |
Comment on lines
+38
to
40
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(value) |
Comment on lines
57
to
59
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max |
Comment on lines
+75
to
77
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_min |
Comment on lines
175
to
177
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def reverse |
Comment on lines
+202
to
204
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_nth_from_end(n) |
Comment on lines
237
to
239
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_first |
Comment on lines
244
to
247
| # method that inserts a given value as a new last node in the linked list | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def add_last(value) |
Comment on lines
265
to
269
| # method that returns the value of the last node in the linked list | ||
| # returns nil if the linked list is empty | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_last |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.