Time - Haben #25
Open
Time - Haben #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 2, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Overall well done, one problem with height, see my comments and let me know what questions you have.
Comment on lines
+32
to
34
| # Time Complexity: | ||
| # Space Complexity: | ||
| def add(key, value) |
Comment on lines
+54
to
+57
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
|
|
||
| def find_recursive(current, key) |
|
|
||
| # Time Complexity: | ||
| # Space Complexity: | ||
| def inorder |
|
|
||
| # Time Complexity: | ||
| # Space Complexity: | ||
| def preorder |
|
|
||
| # Time Complexity: | ||
| # Space Complexity: | ||
| def postorder |
Comment on lines
+130
to
133
| # Time Complexity: | ||
| # Space Complexity: | ||
|
|
||
| def height |
There was a problem hiding this comment.
h is the height of the tree.
However I don't think this method works because it assumes the longest lengths of the trees are on the left and right edges, not somewhere in the middle.
An alternative solution which I think does work
def height_helper(current, count)
return count if current.nil?
return [height_helper(current.left, count + 1), height_helper(current.left, count + 1)].max
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.