space - nora #30
Open
space - nora #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 2, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nora, nice work, you hit the learning goals here. The only comments I have here for you are about time/space complexity. That's one thing to work on.
Comment on lines
+19
to
21
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(log n) | ||
| def add(key, value) |
There was a problem hiding this comment.
👍 , your time/space complexities are correct assuming the tree is balanced.
Comment on lines
+48
to
50
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(log n) | ||
| def find(key) |
There was a problem hiding this comment.
👍 Since you are using a loop the space complexity is actually O(1) since you are not building a system stack.
Comment on lines
+68
to
70
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def inorder |
Comment on lines
+84
to
86
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def preorder |
Comment on lines
+101
to
103
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def postorder |
Comment on lines
+118
to
120
| # Time Complexity: O(n) - worst case for unbalanced, best case O(log n) | ||
| # Space Complexity: O(1) | ||
| def height |
There was a problem hiding this comment.
👍 Since you are doing recursion the space complexity is O(log n) assuming the tree is balanced and O(n) otherwise.
The time complexity is O(n) since you visit each node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.