Ari Herman- Solar System- Octos

[arrriiii]

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
What was the purpose of the initialize method in your class?	The initialize method is called automatically when solar-system class/planet class is called on the object ( i.e. planets).
Describe an instance variable you used and what you used it for.	All of my planets are instance variables to the class Planet. This allowed me to construct a summary of the planet attributes. --Which I could call later when the user needed info on a particular planet.
Describe what the difference would be if your SolarSystem used an Array vs a Hash.	**my SolarSystem class did use an array per request on Wave 2. If it were to use a hash, then I would need to change the iteration in my class to accept key-value pairs. (planets names as the keys and their attributes as the values)
Do you feel like you used consistent formatting throughout your code?	yes. ⌘i is my friend.

[droberts-sea]

Solar System

What We're Looking For

Feature	Feedback
Baseline
Readable code with consistent indentation.	yes
Primary Requirements
Created Custom Solar System Class with initialize, add planet & list planets methods, without using puts.	missing the add_planet method
Planet Class Created	yes
Created a collection of Planet objects as an instance variable in SolarSystem.	yes
Accessor methods created	yes
Method created to return the Planet's attributes and not use puts	yes
Created a user interface to interact with the SolarSystem including adding a planet and viewing a planet's details	yes
Additional Notes	Great job overall! I have a couple of inline comments below that you should check out, but in general I am quite happy with this submission. Keep up the hard work!

[droberts-sea]

I'm not convinced by the name of the block parameter here. arr is not very descriptive - it's not clear to the reader what type of thing you expect it to be. Calling it something like planet might be a better choice.

[droberts-sea]

Ruby files should be named using snake_case. So this one would be solar_system.rb.

The choice is somewhat arbitrary, but when we start working on group projects it will be important for all of us to be doing the same thing.

[droberts-sea]

This strategy of using a switch statement makes it difficult to add new planets. Could you do something like adding a method to SolarSystem to look up a planet by name? That would allow you to show info for user planets as well.

[droberts-sea]

Adding the new planet to planets works, but it's not great form. The purpose of SolarSystem is to keep track of our list of planets, and it's a little confusing to modify the list directly from outside. Instead, you could define a method add_planet on SolarSystem that takes an instance of Planet and adds it to the list.

[droberts-sea]

This is another place where it might make sense to define a method on SolarSystem rather than accessing the list of planets directly.