Skip to content

fix: asyncio issues from multiple caller repos in ci #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GangGreenTemperTatum wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: asyncio issues from multiple caller repos in ci #13

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e6958a
fix: asyncio issues from multiple caller repos in ci
GangGreenTemperTatum Oct 1, 2024
c2489b6
Merge branch 'Addepar:main' into ads/fix-asyncio-issues-multiple-call…
GangGreenTemperTatum Dec 24, 2024
8f49bbb
chore: follow up async slack changes
GangGreenTemperTatum Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions addepar_redflag/util/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,21 @@ def common_arguments(parser, default_config):
parser.add_argument('--no-progress-bar', action='store_false', dest='progress_bar', help='Flag to not display a progress bar.')
parser.add_argument('--no-strip-html-comments', action='store_false', dest='strip_html_comments', help='Flag to not strip HTML comments from PR descriptions.')

async def run_evaluations(github, jira, dataset, config):
await do_evaluations(
github=github,
jira=Jira,
dataset=dataset,
config=config
)

async def run_redflag(github, jira, config):
await redflag(
github=github,
jira=Jira,
slack=Slack,
config=config
)

def cli():
pretty_print_header()
Expand Down Expand Up @@ -72,7 +87,7 @@ def cli():

# Validate Bedrock configuration
final_config['bedrock']['profile'] = validate_aws_credentials(final_config['bedrock']['profile'])

# Instantiate GitHub object
github_token = final_config['github_token']
auth = Auth.Token(github_token) if github_token else None
Expand All @@ -93,7 +108,7 @@ def cli():
MessageType.FATAL
)
exit(1)

jira = Jira(
url=final_config['jira']['url'],
username=jira_user,
Expand Down Expand Up @@ -126,25 +141,22 @@ def cli():
try:
if args.command == 'eval':
dataset = Path(final_config['dataset'])
asyncio.run(do_evaluations(
asyncio.run(run_evaluations(
github=github,
jira=jira,
dataset=dataset,
config=final_config
))
else:
asyncio.run(redflag(
asyncio.run(run_redflag(
github=github,
jira=jira,
slack=slack,
config=final_config
))

# Unhandled exception handler
except Exception as e:
pretty_print(
f'An unhandled exception occurred: {e}',
f'Failed to evaluate against {llm.model}, exception: {e}',
MessageType.FATAL
)
pretty_print_traceback()
exit(1)
exit(1)