Skip to content

Conversation

jeff-matthews
Copy link
Contributor

@jeff-matthews jeff-matthews commented Jul 9, 2025

Purpose of this pull request

This pull request (PR) implements the GetCredential component for the Adobe Commerce as a Cloud Service REST API.

It's based mostly on the AEP implementation, but matches directory and JS file name in upstream repo example (AdobeDocs/adobe-dev-console#140).

The build will probably fail until we have template IDs.

Note

I'm not sure if the RedoclyAPIBlock> component will work the way that we want it to until I deploy to staging. I don't want to deploy to staging until the Developer Console team creates the project template that I requested in CCSAAS-2663.

TODOs

  • Revert to AEP's template_id implementation (see Slack)
  • Confirm whether IMS-related repo secrets need to be added or if adding to YAML files is sufficient (after Devsite team creates templates)
  • Investigate how this affects local dev builds (local dev builds don't have access to env vars the same way stage and prod do)
  • Scrub links to AEP docs (do we need supplemental docs like AEP does?)
  • Validate commerce image (i'm using the icon from ExL, but we may just want to use the plain "A" for DX)
  • Test RedoclyAPIBlock performance; will probably need to revert to hosted schema for performance.

Staging

blocked

whastnew
Enabled a workflow to allow users to get credentials to try the Adobe Commerce as a Cloud Service REST API directly from the reference documentation.

@github-project-automation github-project-automation bot moved this to 📋 Needs Review in Commerce - Pull Requests Jul 9, 2025
@jeff-matthews jeff-matthews self-assigned this Jul 9, 2025
@jeff-matthews jeff-matthews added enhancement New feature or request major-update Significant updates to content labels Jul 9, 2025
@jeff-matthews
Copy link
Contributor Author

As discussed with the team during our DocTechTalk today, I'm going to open a separate PR with the simplified, phase 1 approach (hardcoded) to expedite testing. I'll keep this draft open for reference when we're ready for phase 2 (env vars).

@jeff-matthews
Copy link
Contributor Author

No need to keep this open for reference.

@github-project-automation github-project-automation bot moved this from 📋 Needs Review to 🏁 Done in Commerce - Pull Requests Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major-update Significant updates to content
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant